[RM] Support #86256. Migrated CI to GitHub workflow #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiorgioMegrelli
force-pushed
the
master
branch
16 times, most recently
from
cb6c716 to
46bf5df
Compare
GiorgioMegrelli
changed the title
Nikita-Smirnov-Exactpro
requested changes
Jul 9, 2024
Nikita-Smirnov-Exactpro
left a comment
Nikita-Smirnov-Exactpro
left a comment
There was a problem hiding this comment.
You can look at the https://github.com/th2-net/th2-common-j/blob/5.10.1-dev/build.gradle build script as example
Nikita-Smirnov-Exactpro
requested changes
Jul 10, 2024
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Upload Snapshots | ||
| uses: th2-net/.github/.github/workflows/compound-java-dev.yml@main |
There was a problem hiding this comment.
We shouldn't reuse a workflow template from another group
Comment on lines
25
to
34
| - name: Prepare a tool to detect unwelcome words | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: exactpro-th2/ci-github-action | ||
| ref: master | ||
| token: ${{ secrets.PAT_CI_ACTION }} | ||
| path: ci-github-unwelcome-words-action |
There was a problem hiding this comment.
Looks like this action is broken. So how it should work
- GitHub organisation has private repository with unwelcome words and script of checking git history.
- Action in this repository should checkout the private repository.
- Run action and failure if something wrong.
We should create the same repositories structure in exactpro organisation
Comment on lines
3
to
7
| on: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
this workflow should be run for each commit in not master branch
build.gradle
Outdated
Comment on lines
158
to
160
| id = 'Nikita-Smirnov-Exactpro' | ||
| name = 'Nikita Smirnov' | ||
| email = '[email protected]' |
There was a problem hiding this comment.
Suggested change
| id = 'Nikita-Smirnov-Exactpro' | |
| name = 'Nikita Smirnov' | |
| email = 'nikita.smirnov@exactprosystems.com' | |
| id = 'sf_devs' | |
| name = 'sf_devs' | |
| email = 'sf_devs@exactpro.com' |
id.set("developer")
name.set("developer")
email.set("[email protected]")
quickfixj-core/build.gradle
Outdated
| } | ||
|
|
||
| dependencies { | ||
| if (incremental_build) { |
There was a problem hiding this comment.
Let's remove incremental_build mode because we are going to use github work flow to publish all artifacts
GiorgioMegrelli
force-pushed
the
master
branch
3 times, most recently
from
44ce911 to
a1148cc
Compare
GiorgioMegrelli
force-pushed
the
master
branch
5 times, most recently
from
7a69a3e to
3f3bb07
Compare
…tect unwelcomed words
GiorgioMegrelli
force-pushed
the
master
branch
from
3f3bb07 to
ad9cab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.