Skip to content

Conversation

@OJZen
Copy link

@OJZen OJZen commented Dec 9, 2025

Description

fix: reorder endpoint reset logic in _cdc_close function

This change reorders the endpoint reset logic and interface release in the _cdc_close function to ensure correct resource release order and prevent potential errors during device closure.

Related

Fixes #625 - AEGHB-1338

Testing

I have tested the new code with the project's test app, and all tests passed successfully: "3 Tests 0 Failures 0 Ignored".


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello OJZen, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 5d43e8a

@github-actions github-actions bot changed the title fix: reorder endpoint reset logic in _cdc_close function fix: reorder endpoint reset logic in _cdc_close function (AEGHB-1339) Dec 9, 2025
@OJZen
Copy link
Author

OJZen commented Dec 9, 2025

In this change I removed the first _cdc_reset_transfer_endpoint() call for cdc->data.out_xfer so that the endpoint is only reset once, and I moved the first usb_host_interface_release() (for cdc->notif.intf_desc) to after the 10 ms delay to reduce the chance of releasing an interface while transfers are still in progress.

This has made the behavior more stable in my tests, but I’m still not fully confident it covers all corner cases (e.g. whether a fixed 10 ms delay is always enough or if we should wait explicitly for transfer completion), so I’d appreciate feedback on whether this cleanup/order is appropriate and if there is a more robust pattern we should follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[USB Host CDC] Redundant reset of out_xfer in _cdc_close function (AEGHB-1338)

1 participant