-
Notifications
You must be signed in to change notification settings - Fork 43
Chore/update hugo theme to latest upstream #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
f-hollow
wants to merge
13
commits into
espressif:main
Choose a base branch
from
f-hollow:chore/update-hugo-theme-to-latest-upstream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chore/update hugo theme to latest upstream #599
f-hollow
wants to merge
13
commits into
espressif:main
from
f-hollow:chore/update-hugo-theme-to-latest-upstream
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
987b96d to
84b8829
Compare
84b8829 to
9200efa
Compare
9200efa to
a700030
Compare
Collaborator
Author
|
@pedrominatel PTAL. I updated the ChatBot welcome message as we agreed some time ago. Please double check it. |
31451a9 to
34b2e31
Compare
34b2e31 to
24d8f7b
Compare
|
🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr599/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the versions of the software:
0.147.50.152.2(latest supported by Blowfish v2.92.0)v2.86.00b06a64139beba6287e7685f4c810ad4ff772fdeTue May 27 01:03:33 2025 +0100v2.92.081f0e887100f4ddc9856c6d662883b62ab7b1043Mon Nov 3 22:34:25 2025 +0000Fixes and improvements from incorporating the Blowfish updates
Incorporating the upstream changes to overridden files brought the following benefits:
Scroll to topnow appears in the bottom-right cornerOther improvements
Background information
As you might know, the
espressif/blowfishrepo is added to ourdeveloper-portalrepo as a submodule in the folderthemes/blowfish/. Over time, we copied a few Blowfish layout files fromthemes/blowfish/layouts/tolayouts/and applied some changes. Comparing the files inthemes/blowfish/layouts/with our overridden versions inlayouts/revealed considerable updates in the former (submodule).We usually fast-forward the Blowfish submodule changes once in a few months and only incorporate the upstream changes from
themes/blowfish/layouts/into respective overridden files if the website fails to build or if we discover critical issues. One of such issues was non-functioning burger menu button fixed in PR #362.Although, skipping incorporation of non-critical upstream changes saves our time, it leads to accumulating maintenance debt. Ideally, we need to incorporate the upstream changes to our overriden files at least once a year.
I decided to partially incorporate the upstream changes as this will help us better prepare for implementing our own updates planned for the near future, such as adding the Dark theme and improving the main page.
This time, I did the following:
layouts/files with their repective copies inthemes/blowfish/layouts/at the time of applying these changesv2.92.0. This task usually requires considerable efforts in figuring out how to implement the changes as simple copying and pasting is usually not possible.As a result, the following files have been updated:
layouts/partials/article-link/card-related.htmllayouts/partials/article-link/card.htmllayouts/partials/footer.htmllayouts/partials/head.htmllayouts/partials/header/basic.htmllayouts/partials/hero/basic.htmllayouts/partials/toc.html(removed as it has no overrides)layouts/_default/baseof.htmllayouts/_default/single.htmlWith these updates, the website builds stably. No major bugs have been identified so far.
Related
Testing
The changes have been compared visually to the existing online version and a number of local tests were done.
Checklist
Before submitting a Pull Request, please ensure the following: