feat: add engine subcommands to expert #254
Conversation
set no_return() to run/1
rmand97
force-pushed
the
feat/expert-engine-subcommands
branch
from
711e699 to
a7a5bdb
Compare
| # Handle engine subcommand first (before starting the LSP server) | ||
| case argv do | ||
| ["engine" | engine_args] -> | ||
| Expert.Engine.run(engine_args) |
There was a problem hiding this comment.
Can you make this return the exit code, and put the System.halt(exit_code) part here?
That'll make the unit tests easier to write, as well as pull the halting part up to the top level.
This way it's very clear that the program stops after this code runs.
There was a problem hiding this comment.
Will do.
Just a quick question. Would you like it to always return success (0), event though it fails deleting a file?
like if its fails the middle one of 3 files in expert clean --force it will continue after failing, logging something went wrong, and delete the last one and return 0. Or would like it to stop after failing and return 1?
There was a problem hiding this comment.
If it fails any, lets return a non zero exit code (1).
| end | ||
|
|
||
| @spec print_help() :: no_return() | ||
| defp print_help do |
There was a problem hiding this comment.
Let's also add help text to each subcommand, and the options can be presented for the relevant subcommand.
So in the existing help text here, we won't have any options, and the --force option will show up in the help text for the clean subcommand
3 participants
closes #209
Taking a stab at the issue. Hoping I understood it correctly.