Skip to content

fix: wrong return value caused metric sending to fail sometimes #3638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icehaunter merged 1 commit into from
Dec 24, 2025
Merged

fix: wrong return value caused metric sending to fail sometimes #3638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/brown-ducks-admire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@core/sync-service': patch
---

fix: wrong return value caused metric sending to fail sometimes
5 changes: 4 additions & 1 deletion packages/sync-service/lib/electric/shapes/consumer_registry.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ defmodule Electric.Shapes.ConsumerRegistry do

@spec active_consumer_count(stack_id()) :: non_neg_integer()
def active_consumer_count(stack_id) when is_binary(stack_id) do
:ets.info(ets_name(stack_id), :size)
case :ets.info(ets_name(stack_id), :size) do
:undefined -> 0
size -> size
end
rescue
ArgumentError -> 0
end
Expand Down