Skip to content

Conversation

@alco
Copy link
Member

@alco alco commented Dec 12, 2025

Different commands are used for checking TS and Elixir code formatting and so it makes sense to use different path filters for them. We can vary path filters only at the workflow level, hence the split into separate workflows.

I have also found a problem in the cache keys where, due to incorrect variable interpolation syntax, the hashFiles() function was always returning an empty string.

@alco alco force-pushed the alco/ci-formatting-checks branch from d6da051 to 8df7bd2 Compare December 12, 2025 12:26
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.69%. Comparing base (c669280) to head (3bea944).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3591      +/-   ##
==========================================
- Coverage   75.79%   75.69%   -0.11%     
==========================================
  Files          51       51              
  Lines        2752     2752              
  Branches      411      411              
==========================================
- Hits         2086     2083       -3     
- Misses        664      667       +3     
  Partials        2        2              
Flag Coverage Δ
electric-telemetry 22.99% <ø> (+0.27%) ⬆️
elixir 57.47% <ø> (-0.27%) ⬇️
elixir-client 73.94% <ø> (-0.53%) ⬇️
packages/experimental 87.73% <ø> (ø)
packages/react-hooks 86.48% <ø> (ø)
packages/typescript-client 93.80% <ø> (ø)
packages/y-electric 55.66% <ø> (ø)
typescript 88.13% <ø> (ø)
unit-tests 75.69% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alco alco force-pushed the alco/ci-formatting-checks branch from 8df7bd2 to 964cae2 Compare December 12, 2025 12:32
@alco alco changed the title Split formatting checks for TS and Elixir into separate workflows ci: Split formatting checks for TS and Elixir into separate workflows Dec 13, 2025
@alco alco force-pushed the alco/ci-formatting-checks branch from 964cae2 to 3bea944 Compare December 15, 2025 15:55
@alco alco merged commit 7f24b70 into main Dec 15, 2025
28 checks passed
@alco alco deleted the alco/ci-formatting-checks branch December 15, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants