Skip to content

Conversation

@msfstef
Copy link
Contributor

@msfstef msfstef commented Dec 10, 2025

We need NPM CLI >= 11.5.1 for OIDC to work as per the Trusted Publisher docs which comes bundled with node v24

Upgrading node to v24 caused some issues with JSDOM and the fetch polyfills - which can be fixed by upgrading vitest to the latest version.

I've refrained from upgrading any other deps to not complicate this PR any further. This is the minimum viable thing to upgrade it.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.27%. Comparing base (e18adca) to head (34402a0).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3580      +/-   ##
==========================================
+ Coverage   75.21%   75.27%   +0.05%     
==========================================
  Files          51       51              
  Lines        2744     2742       -2     
  Branches      408      406       -2     
==========================================
  Hits         2064     2064              
+ Misses        678      676       -2     
  Partials        2        2              
Flag Coverage Δ
electric-telemetry 22.71% <ø> (ø)
elixir 57.38% <ø> (ø)
elixir-client 73.94% <ø> (ø)
packages/experimental 87.73% <ø> (ø)
packages/react-hooks 86.48% <ø> (ø)
packages/typescript-client 93.08% <ø> (ø)
packages/y-electric 55.66% <ø> (+0.54%) ⬆️
typescript 87.56% <ø> (+0.10%) ⬆️
unit-tests 75.27% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@msfstef msfstef changed the title chore: Specify NPM version chore: Upgrade node to v24 Dec 10, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 10, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@electric-sql/react@3580
npm i https://pkg.pr.new/@electric-sql/client@3580
npm i https://pkg.pr.new/@electric-sql/y-electric@3580

commit: 34402a0

@msfstef msfstef requested a review from KyleAMathews December 10, 2025 18:10
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@msfstef msfstef merged commit 8c83a71 into main Dec 11, 2025
59 of 61 checks passed
@msfstef msfstef deleted the msfstef/upgrade-npm branch December 11, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants