-
Notifications
You must be signed in to change notification settings - Fork 295
chore: Upgrade node to v24 #3580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
==========================================
+ Coverage 75.21% 75.27% +0.05%
==========================================
Files 51 51
Lines 2744 2742 -2
Branches 408 406 -2
==========================================
Hits 2064 2064
+ Misses 678 676 -2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
commit: |
KyleAMathews
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
We need NPM CLI >= 11.5.1 for OIDC to work as per the Trusted Publisher docs which comes bundled with node v24
Upgrading node to v24 caused some issues with JSDOM and the fetch polyfills - which can be fixed by upgrading vitest to the latest version.
I've refrained from upgrading any other deps to not complicate this PR any further. This is the minimum viable thing to upgrade it.