Consolidate linting tools into single CI job #3445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, linting/formatting errors would cause multiple CI jobs to
fail simultaneously (often 7+ jobs), making it confusing to identify
the actual issue and slowing down CI feedback.
Changes:
- Created new autoformat.yml workflow that runs all linting/formatting
checks in a single job:
- TypeScript prettier formatting check
- TypeScript eslint checks (all packages)
- Elixir mix format check
- Elixir compilation warnings check
- Removed redundant linting checks from other workflows:
- ts_test.yml: Removed stylecheck and format:check from package
and example checking jobs (kept typecheck for actual type errors)
- elixir_tests.yml: Removed the separate formatting job
- integration_tests.yml: Removed --warnings-as-errors flag from
compile step
Now linting/formatting errors will only cause the single autoformat
job to fail, while other test jobs focus on functional testing.
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3445 +/- ##
==========================================
+ Coverage 67.45% 73.37% +5.91%
==========================================
Files 180 28 -152
Lines 9671 1198 -8473
Branches 359 107 -252
==========================================
- Hits 6524 879 -5645
+ Misses 3145 318 -2827
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Separate the formatting checks into two independent jobs that run in parallel: - typescript_formatting: Prettier and ESLint checks for TS/JS code - elixir_formatting: mix format and compilation warnings for Elixir This ensures failures in one language ecosystem don't block feedback from the other, and both can run concurrently.
kevin-dp
approved these changes
Nov 18, 2025
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…nting-ci-016xvNjnWVXhLGTq3t7u1VVD
KyleAMathews
deleted the
claude/consolidate-linting-ci-016xvNjnWVXhLGTq3t7u1VVD
branch
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, linting/formatting errors would cause multiple CI jobs to fail simultaneously (often 7+ jobs), making it confusing to identify the actual issue and slowing down CI feedback.
Changes:
Created new autoformat.yml workflow that runs all linting/formatting checks in a single job:
Removed redundant linting checks from other workflows:
Now linting/formatting errors will only cause the single autoformat job to fail, while other test jobs focus on functional testing.