Skip to content

Conversation

@KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Oct 10, 2025

Reverts #3270

  • disable prettier on website md as prettier escapes underscores which vitepress extensively uses for file imports
  • remove per-example eslint configs in favor of one global one
  • disable deploys for examples for now until that's fixed

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.11%. Comparing base (d539102) to head (5fcad8d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3271      +/-   ##
==========================================
- Coverage   72.14%   72.11%   -0.04%     
==========================================
  Files         183      183              
  Lines        9788     9788              
  Branches      331      335       +4     
==========================================
- Hits         7062     7059       -3     
- Misses       2724     2727       +3     
  Partials        2        2              
Flag Coverage Δ
elixir 69.65% <ø> (-0.03%) ⬇️
elixir-client 73.94% <ø> (ø)
packages/experimental 87.73% <ø> (-1.23%) ⬇️
packages/react-hooks 86.48% <100.00%> (ø)
packages/typescript-client 94.39% <ø> (+0.10%) ⬆️
packages/y-electric 55.12% <ø> (ø)
postgres-140000 69.18% <ø> (+0.16%) ⬆️
postgres-150000 69.12% <ø> (-0.03%) ⬇️
postgres-170000 68.92% <ø> (-0.06%) ⬇️
postgres-180000 68.96% <ø> (-0.11%) ⬇️
sync-service 69.22% <ø> (-0.03%) ⬇️
typescript 87.28% <100.00%> (-0.08%) ⬇️
unit-tests 72.11% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Fix escaped underscores in VitePress file inclusion syntax
- Update VitePress config to ignore /AGENTS and localhost dead links
- Add website markdown files to .prettierignore to prevent future issues
- Disable automatic example deployments (currently broken)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@netlify
Copy link

netlify bot commented Oct 10, 2025

Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit 8f6445c
🔍 Latest deploy log https://app.netlify.com/projects/electric-next/deploys/68e91a5203cfd900080d780a
😎 Deploy Preview https://deploy-preview-3271--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

KyleAMathews and others added 3 commits October 10, 2025 08:37
Run prettier to fix formatting issues in changeset files and website config.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Prettier has unstable formatting for this CSS file, causing it to
be reformatted differently each time. Ignore it to prevent CI failures.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
The --ext flag is no longer supported in ESLint 9 with flat config.
File extensions are now configured in eslint.config.js.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
KyleAMathews and others added 4 commits October 10, 2025 08:46
The .shared folder uses ESLint 8 with old config format, which
requires --ext flag to check TypeScript files. The root flat config
ignores examples/** so this folder needs explicit file extensions.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
The root eslint.config.mjs flat config causes ESLint to reject the
--ext flag even in subdirectories with .eslintrc.cjs files. Remove
--ext from all example package.json scripts. The local .eslintrc.cjs
configs will still determine which file types to lint.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Remove all 14 individual example ESLint configs and use a single root
config for consistency across the monorepo. The root config now includes:
- TypeScript unused-vars rule with underscore pattern support
- Backtick quotes enforcement
- Proper TypeScript parser configuration

All examples now use the same linting rules, simplifying maintenance.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
- Remove all React Compiler and React hooks eslint-disable comments from linearlite
- Add eslint-disable for quotes in module declarations (required syntax)
- Fix import() quote in tanstack-db-web-starter (backticks not allowed)
- Rename unused parseError to _parseError in typescript-client test

These changes fix ESLint errors after consolidating configs to root.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@electric-sql electric-sql deleted a comment from github-actions bot Oct 10, 2025
@balegas
Copy link
Contributor

balegas commented Oct 10, 2025

I'll also approve a ""Rever "Revert "Revert....

@KyleAMathews
Copy link
Contributor Author

I'll also approve a ""Rever "Revert "Revert....

Very agreeable you are!

@KyleAMathews KyleAMathews merged commit 702bbeb into main Oct 10, 2025
44 checks passed
@KyleAMathews KyleAMathews deleted the revert-3270-alco/revert-formatting-changes branch October 10, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants