fix: wrong return value caused metric sending to fail sometimes

[icehaunter]

Found in the logs with:

Task #PID<0.x.0> started from :"stack_otel_telemetry_<stack_id>" terminating
** (Protobuf.EncodeError) Failed to encode body: Got error when encoding OtelMetricExporter.Opentelemetry.Proto.Collector.Metrics.V1.ExportMetricsServiceRequest#resource_metrics: ** (Protobuf.EncodeError) Got error when encoding OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.ResourceMetrics#resource: ** (Protobuf.EncodeError) Got error when encoding OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.ResourceMetrics#scope_metrics: ** (Protobuf.EncodeError) Got error when encoding OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.ScopeMetrics#scope: ** (Protobuf.EncodeError) Got error when encoding OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.ScopeMetrics#metrics: ** (Protobuf.EncodeError) Got error when encoding OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.Metric#name: ** (Protobuf.EncodeError) Got error when encoding OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.Metric#description: ** (Protobuf.EncodeError) Got error when encoding OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.Metric#unit: ** (Protobuf.EncodeError) Got error when encoding OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.Metric#gauge: ** (Protobuf.EncodeError) Got error when encoding OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.Gauge#data_points: ** (Protobuf.EncodeError) Got error when encoding OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.NumberDataPoint#start_time_unix_nano: ** (Protobuf.EncodeError) Got error when encoding OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.NumberDataPoint#time_unix_nano: ** (Protobuf.EncodeError) Got error when encoding OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.NumberDataPoint#as_double: ** (ArgumentError) construction of binary failed: segment 1 of type 'float': expected a float or an integer but got: :undefined

Body (cleaned manually):

%OtelMetricExporter.Opentelemetry.Proto.Collector.Metrics.V1.ExportMetricsServiceRequest{
  resource_metrics: [
    %OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.ResourceMetrics{
      resource: %OtelMetricExporter.Opentelemetry.Proto.Resource.V1.Resource{},
      scope_metrics: [
        %OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.ScopeMetrics{
          scope: %OtelMetricExporter.Opentelemetry.Proto.Common.V1.InstrumentationScope{},
          metrics: [
            %OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.Metric{
              name: "electric.shapes.active_shapes.count",
              data: {:gauge,
               %OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.Gauge{
                 data_points: [
                   %OtelMetricExporter.Opentelemetry.Proto.Metrics.V1.NumberDataPoint{
                     value: {:as_double, :undefined},
                   }
                 ],
                 __unknown_fields__: []
               }},
              __unknown_fields__: []
            }
            # more metrics...
          ]
        }
      ]
    }
  ]
}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.76%. Comparing base (f6e7c75) to head (2c6d17a).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3638   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          18       18           
  Lines        1676     1676           
  Branches      424      428    +4     
=======================================
  Hits         1471     1471           
  Misses        203      203           
  Partials        2        2           

Flag	Coverage Δ
packages/experimental	87.73% <ø> (ø)
packages/react-hooks	86.48% <ø> (ø)
packages/typescript-client	93.66% <ø> (ø)
packages/y-electric	56.05% <ø> (ø)
typescript	87.76% <ø> (ø)
unit-tests	87.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

This PR has been released! 🚀

The following packages include changes from this PR:

• @core/[email protected]

Thanks for contributing to Electric!