Skip to content

Conversation

@md-adil
Copy link

@md-adil md-adil commented Dec 4, 2025

What does this pull request do?

This makes it clear which symbols are part of the public API and improves IDE autocomplete and static analysis for Python integrations using this package.

@md-adil md-adil requested a review from a team as a code owner December 4, 2025 19:06
@cla-checker-service
Copy link

cla-checker-service bot commented Dec 4, 2025

💚 CLA has been signed

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Dec 4, 2025
@md-adil
Copy link
Author

md-adil commented Dec 5, 2025

❌ Author of the following commits did not sign a Contributor Agreement: 5dd814b

Please, read and sign the above mentioned agreement if you want to contribute to this project

Hi team, I’ve already signed the Elastic CLA, but the CLA check on this PR still shows “not signed” and asks me to sign again.

I verified:

  • I used the same GitHub account while signing the CLA.
  • My Git commit email matches my GitHub primary email.

Could you please re-trigger or manually validate the CLA check?
Thanks!

@xrmx
Copy link
Member

xrmx commented Dec 9, 2025

cla/check

Copy link
Member

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cla/check

@xrmx
Copy link
Member

xrmx commented Dec 9, 2025

@md-adil If you look at the commit history in https://github.com/elastic/apm-agent-python/pull/2504/commits you'll see that your commit is not linked to your account. I guess that's because you commit with an email that is different than the one you use on github. I think that's the reason CLA check is red.

@md-adil md-adil force-pushed the publicly-exposed-variables branch from 5dd814b to 05de2c5 Compare December 9, 2025 14:58
@md-adil
Copy link
Author

md-adil commented Dec 9, 2025

@md-adil If you look at the commit history in https://github.com/elastic/apm-agent-python/pull/2504/commits you'll see that your commit is not linked to your account. I guess that's because you commit with an email that is different than the one you use on github. I think that's the reason CLA check is red.

Yep thanks,

i was just checking account, not the commit.
it's done!


from elasticapm.contrib.asyncio.traces import async_capture_span # noqa: F401 E402

__all__ = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it could you please sort the entries?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-python community Issues opened by the community triage Issues awaiting triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants