-
Notifications
You must be signed in to change notification settings - Fork 235
updated the __all__ section to include all 22 publicly exposed varia… #2504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
💚 CLA has been signed |
🤖 GitHub commentsJust comment with:
|
Hi team, I’ve already signed the Elastic CLA, but the CLA check on this PR still shows “not signed” and asks me to sign again. I verified:
Could you please re-trigger or manually validate the CLA check? |
|
cla/check |
xrmx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cla/check
|
@md-adil If you look at the commit history in https://github.com/elastic/apm-agent-python/pull/2504/commits you'll see that your commit is not linked to your account. I guess that's because you commit with an email that is different than the one you use on github. I think that's the reason CLA check is red. |
5dd814b to
05de2c5
Compare
Yep thanks, i was just checking account, not the commit. |
|
|
||
| from elasticapm.contrib.asyncio.traces import async_capture_span # noqa: F401 E402 | ||
|
|
||
| __all__ = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are at it could you please sort the entries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
What does this pull request do?
This makes it clear which symbols are part of the public API and improves IDE autocomplete and static analysis for Python integrations using this package.