fix(types): relax variant behavior on incompatible props #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`variant` blocking on "incompatible props" use-case is bad for DX it only protects against bad spreads, which are antipattern anyway
zerobias
approved these changes
Jun 16, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR relaxes the variant type behavior so that incompatible props across cases are allowed, updating the tests to reflect the new union-based prop requirements and error conditions.
- Replace strict
expectType<React.FC>checks with direct JSX usage to validate relaxed prop constraints - Add positive and negative usage examples for various
variantconfigurations - Remove unnecessary blocking of incompatible props between cases
Comments suppressed due to low confidence (2)
type-tests/types-variant.tsx:34
- The original
expectType<React.FC>(VariableInput)assertion was removed here, which loses an explicit check thatVariableInputis a React functional component. Consider re-adding anexpectTypeassertion to maintain coverage on component shape.
<VariableInput />;
type-tests/types-variant.tsx:93
- Typo in comment:
possbleshould bepossible.
// variant allows not to set every possble case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variantblocking on "incompatible props" use-case is bad for DX it only protects against bad spreads, which are antipattern anyway