Add handling of leading/trailing edges
#283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🚛 size-compare reportComparing 786f7452...786f7452 Files wasn't changed
|
Member
|
Awesome! Could you also add some tests to https://github.com/effector/patronum/blob/main/src/throttle/throttle.fork.test.ts and some type tests to https://github.com/effector/patronum/blob/main/test-typings/throttle.ts ? |
|
|
||
| const triggerTick = createEvent<T>(); | ||
|
|
||
| const $leading = toStoreBoolean(leading, '$leading', false); |
Contributor
There was a problem hiding this comment.
In lodash both leading and trailing are true by default. Why not make the same?
Author
There was a problem hiding this comment.
I didn't want to change the default behavior making it breaking change, but I agree, I'd rather made them both true by default
Toleckk
reviewed
May 16, 2023
| const $leading = toStoreBoolean(leading, '$leading', false); | ||
| const $trailing = toStoreBoolean(trailing, '$trailing', true); | ||
|
|
||
| const $neverCalled = createStore(true).on(target, () => false); |
There was a problem hiding this comment.
This one should be reset every time when timeout finishes, I guess
const trigger = createEvent()
const throttled = throttle({ source: trigger, timeout: 100, leading: true })
trigger(1)
trigger(2)
trigger(3)
await wait(110)
trigger(4)throttled should be called with 4 immediately
sergeysova
changed the title
leading/trailing edges
sergeysova
added
enhancement
sergeysova
requested changes
May 25, 2023
|
|
||
| const triggerTick = createEvent<T>(); | ||
|
|
||
| const $leading = toStoreBoolean(leading, '$leading', false); |
Member
There was a problem hiding this comment.
Suggested change
| const $leading = toStoreBoolean(leading, '$leading', false); | |
| const $leading = toStoreBoolean(leading ?? false, '$leading'); |
| const triggerTick = createEvent<T>(); | ||
|
|
||
| const $leading = toStoreBoolean(leading, '$leading', false); | ||
| const $trailing = toStoreBoolean(trailing, '$trailing', true); |
Member
There was a problem hiding this comment.
Suggested change
| const $trailing = toStoreBoolean(trailing, '$trailing', true); | |
| const $trailing = toStoreBoolean(trailing ?? true, '$trailing'); |
Comment on lines
+122
to
+133
| function toStoreBoolean( | ||
| value: boolean | Store<boolean> | undefined, | ||
| name: string, | ||
| defaultValue: boolean, | ||
| ): Store<boolean> { | ||
| if (is.store(value)) return value; | ||
| if (typeof value === 'boolean') { | ||
| return createStore(value, { name }); | ||
| } else { | ||
| return createStore(defaultValue, { name }); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| function toStoreBoolean( | |
| value: boolean | Store<boolean> | undefined, | |
| name: string, | |
| defaultValue: boolean, | |
| ): Store<boolean> { | |
| if (is.store(value)) return value; | |
| if (typeof value === 'boolean') { | |
| return createStore(value, { name }); | |
| } else { | |
| return createStore(defaultValue, { name }); | |
| } | |
| } | |
| function toStoreBoolean(value: boolean | Store<boolean> | undefined, name: string): Store<boolean> { | |
| if (is.store(value)) return value; | |
| return createStore(value, { name }); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #37
Checklist for a new method
srcdirectory inparam-casesrc/method-name/index.tsin ESModules export incamelCasenamed exportsrc/method-name/method-name.test.tssrc/method-name/method-name.fork.test.tstest-typings/method-name.ts// @ts-expect-errorto mark expected type errorimport { expectType } from 'tsd'to check expected return typesrc/method-name/readme.mdPatronum/MethodNameMotivation,Formulae,ArgumentsandReturnsections for each overloadExamplesection for each overloadREADME.mdin the repository root- [MethodName](#methodname) - description.## MethodName[Method documentation & API](/src/method-name)into section