Skip to content

refactor(dataset-store): extract amp-providers-registry crate #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shiyasmohd wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor(dataset-store): extract amp-providers-registry crate #1564

shiyasmohd wants to merge 4 commits into from
+1,039 −336

Conversation

@shiyasmohd
Copy link
Contributor

@shiyasmohd shiyasmohd commented Jan 16, 2026 •
edited
Loading

  • Extract amp-providers-registry crate from amp-dataset-store
  • Update admin-api to use DatasetsRegistry directly for registry operations
  • Introduce Dataset trait
    • Introduces a Dataset trait in datasets-common
    • Moves JsUdf from common to js-runtime
    • Adds udf module re-exports in datasets-common
    • Updates all extractors to implement the new Dataset trait
    • Updates imports across the codebase

Closes #1558

@shiyasmohd shiyasmohd changed the title refactor(dataset-store): extract amp-providers-registry crate refactor(dataset-store): extract amp-providers-registry crate Jan 16, 2026
@shiyasmohd shiyasmohd self-assigned this Jan 16, 2026
@shiyasmohd shiyasmohd requested a review from LNSD January 16, 2026 08:05
LNSD
LNSD reviewed Jan 16, 2026
View reviewed changes
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/amp-providers-registry branch 2 times, most recently from 393944f to 347801d Compare January 18, 2026 10:10
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/amp-providers-registry branch from 347801d to 275a524 Compare January 18, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LNSD LNSD LNSD left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@shiyasmohd shiyasmohd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor(dataset-store): extract amp-providers-registry crate

3 participants

@shiyasmohd @LNSD