T/improve unmarshal, better error msgs and partial obj ref link support #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this creates the missing object references with dummy entries to at least make iVar object references work It works here with gitlab's old language-stats.cache format parsing mutliple GB of output files successfully. WARNING: this may open a can of worms with data that was "correctly" rejected before being parsed now, but possible corrupted or creating new runtime error behaviours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
obj ref-link support is actually a hack that creates dummy refs for hashes and arrays, but it works at least to make all iVar refs resolveable correctly (tested with GB's of gitlab
language-stats.cachefiles)