-
Notifications
You must be signed in to change notification settings - Fork 1
* first cut at a "dnstapir-cli edm stats" command #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe PR registers a new EdmCmd subcommand in the root command and adds a local module replacement in go.mod to point the tapir dependency to a local directory instead of a remote version. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@go.mod`:
- Around line 5-6: The go.mod currently has a local replace directive "replace
github.com/dnstapir/tapir => ../tapir" which breaks CI; remove that replace
directive from go.mod before merging and either update the require for
github.com/dnstapir/tapir to the published version you need or keep the PR as a
draft until the tapir changes are published so CI can resolve the dependency.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
cmd/root.gogo.mod
🧰 Additional context used
🪛 GitHub Actions: Build
cmd/root.go
[error] 16-16: Build failed: replacement directory '../tapir' does not exist for github.com/dnstapir/[email protected] during go build.
🔇 Additional comments (1)
cmd/root.go (1)
57-59: EdmCmd registration follows the established pattern.The command registration at line 58 is consistent with how
PopCmd,DawgCmd,ApiCmd,FilterlistsCmd,EnrollCmd, andRenewCmdare added. The syntax is identical and the import source matches other commands. The go.mod replacement forgithub.com/dnstapir/tapiris properly configured pointing to the local../tapirdirectory.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| replace github.com/dnstapir/tapir => ../tapir | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the local replace directive before merging — this breaks CI.
The replace directive points to a local ../tapir directory that doesn't exist in CI, causing the build to fail. Local replacements are useful during development but should not be committed to main.
Options:
- Remove the
replacedirective and publish the requiredtapirchanges first, then update the version inrequire. - If the tapir changes aren't ready for release, consider keeping this PR as a draft until they are.
🤖 Prompt for AI Agents
In `@go.mod` around lines 5 - 6, The go.mod currently has a local replace
directive "replace github.com/dnstapir/tapir => ../tapir" which breaks CI;
remove that replace directive from go.mod before merging and either update the
require for github.com/dnstapir/tapir to the published version you need or keep
the PR as a draft until the tapir changes are published so CI can resolve the
dependency.
|
Don't forget to update techdocs |
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.