Moving 5 PB modules from Webpack to RS Build #6837
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing that plagues DNN is our build time. This is largely due to the building of the various react projects of the PersonaBar and the common libraries behind this.
This PR switches out Webpack for RSBuild for the Servers, Seo, Security, Roles and Prompt modules. RSBuild is widely regarded as the next best thing in terms of build performance even beating Vite. In local testing building the aforementioned modules sped up from say 15 seconds to just over a second.
But the build is slightly different. For a number of modules the css used to be included in the javascript. The proposed changes all pull out the CSS to its own file. This means careful checking is needed nothing has nudged/changed/etc.
Another change is that the proposed system doesn't support hot reload. But that never worked for me in the past, so I'm not sure it's a change. If someone is using this I'd love to hear.
I'd love to hear from others what they think.
To run this:
yarn installyarn run watch --scope <modulename>For the modulename check the package.json. I.e. "prompt" for the Prompt module but "security-settings" for the Security module.