Fixing Yarn1 erroring with failed to replace env

[honeyankit]

Context

If a repo has multiple .npmrc files, Dependabot only rewrites one of them to remove variables. NPM doesn't have an issue but Yarn 1 is not ok and errors out.

This issue was fixed in the PR but one of the edge case was to leading to raise the issue again.

Edge case:
User root dir contained the .npmrc file with it's sub-dir (foo/bar/foo1/bar1/yarn.lock). The Dependabot npm job was failing for path /foo/bar/foo1/bar1 with the below error:

updater | 2023/07/13 16:04:33 ERROR <job_694149843> Failed to replace env in config: ${ARTIFACTORY_PASSWORD}
updater | 2023/07/13 16:04:33 ERROR <job_694149843> /home/dependabot/common/lib/dependabot/shared_helpers.rb:131:in `run_helper_subprocess'
updater | 2023/07/13 16:04:33 ERROR <job_694149843> /home/dependabot/npm_and_yarn/lib/dependabot/npm_and_yarn/file_updater/yarn_lockfile_updater.rb:191:in `run_yarn_top_level_updater'
updater | 2023/07/13 16:04:33 ERROR <job_694149843> /home/dependabot/npm_and_yarn/lib/dependabot/npm_and_yarn/file_updater/yarn_lockfile_updater.rb:114:in `block (2 levels) in run_yarn_updater'

Approach

The modified code now checks all the parent directories for .npmrc files, whereas the previous code used to stopped, if a directory did not have one. Now I have removed the break statement and continually performing dirs.pop in each iteration, the loop in the modified code advances up to the root directory. This modification make sures that all relevant .npmrc files are addressed. Also a minor regex change was done in the gsub technique for non-greedy matching.

[honeyankit]

I have test it with Dependabot CLI and it passes and creates the PR successfully

[honeyankit]

Create a smoke test for the same: dependabot/smoke-tests#113

[abdulapopoola]

I assume this was breaking and not walking through the entire dirs right?

[honeyankit]

Yes. If the subdir did not contain the .npmrc file then it was breaking out. In such case if the repo root dir still had .npmrc file then error was getting raised.

[deivid-rodriguez]

Looks great, nice catch!

Just had a question, purely out of curiosity!