[Spark] Plumbing the table feature properties to server when create a table. #5629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Li <[email protected]>
yili-db
commented
Dec 4, 2025
| kv | ||
| case lKey if lKey.startsWith(TableFeatureProtocolUtils.FEATURE_PROP_PREFIX) => | ||
| // This is a table feature, we should allow it. | ||
| lKey -> value |
Collaborator
Author
There was a problem hiding this comment.
lKey is the lower case. changing it to key to retain the original case.
yili-db
commented
Dec 4, 2025
| partitionColumnNames = Nil, | ||
| properties = UpdateCatalog.updatedProperties(snapshot) | ||
| ++ additionalProperties, | ||
| ++ additionalProperties ++ tableProtocolProperties, |
Collaborator
Author
There was a problem hiding this comment.
To be conservative, adding back just the protocol properties plus the uc table id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Plumbing the table feature properties to server when create a table.
These table properties need to be set if Delta creates a managed table with catalogManaged feature on UC.
How was this patch tested?
Does this PR introduce any user-facing changes?
No.