HCD-157: Fix exclusion of *.SF and license files from dtest-jar #2187
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
Exclusion of *.SF files from jar that get packaged into the dtest-jar does not work as expected. As a result if a jar contains the *.SF file, like for instance the org.eclipse.jdt:ecj dependency, then the ECLIPSE_.SF file get packaged into the dtest-jar. In dependent projects like HCD, this results in dtest-jar missing from classpath, which causes runtime exceptions. This patch ports the dtest jar packaging code from C* 5, which uses an approach of unpackaging all the jars, then filtering the files to remove the undesired metadata and finally it repackages the classes into a fat jar.
szymon-miezal
force-pushed
the
HCD-157
branch
from
3842904 to
faa43fe
Compare
|
❌ Build ds-cassandra-pr-gate/PR-2187 rejected by Butler3 regressions found Found 3 new test failures
Found 1 known test failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
Exclusion of *.SF files from jar that get packaged into the dtest-jar does not work as expected.
As a result if a jar contains the *.SF file, like for instance the org.eclipse.jdt:ecj dependency, then the
ECLIPSE_.SFfile get packages into the dtest-jar. It dependent projects like HCD, it results in dtest-jar missing from classpath, which causes runtime exceptions.What does this PR fix and why was it fixed
This patch ports the dtest jar packaging code from C* 5, which uses an approach of unpackaging all the jars, then filtering the files to remove the undesired metadata and finally it repackages the classes into a fat jar.
CNDB PR: https://github.com/riptano/cndb/pull/16382