Skip to content

Conversation

@AnkitCLI
Copy link
Contributor

@AnkitCLI AnkitCLI commented Oct 14, 2025

This PR contains e2e test cases for google drive source plugin including locators, actions and stepdesigns classes.

@AnkitCLI AnkitCLI added the build label Oct 14, 2025
@AnkitCLI AnkitCLI force-pushed the driveE2E branch 9 times, most recently from df2d108 to e1b9ad1 Compare October 15, 2025 19:15
@AnkitCLI AnkitCLI marked this pull request as ready for review October 15, 2025 20:00
Feature: Google Drive Batch Source - Runtime Scenarios

@BATCH-TS-GD-MACRO-01 @BQ_SINK_TEST
Scenario: Validate successful records transfer from GoogleDrive to BigQuery with macro arguments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this scenario in cucumber reports?

Copy link
Contributor Author

@AnkitCLI AnkitCLI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some new steps for macro feature. Now you will able to see in the report as well.

@AnkitCLI AnkitCLI force-pushed the driveE2E branch 2 times, most recently from d53cbe2 to fd69463 Compare October 16, 2025 07:00
pom.xml Outdated
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>2.18.1</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move version to properties.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

pom.xml Outdated
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<version>3.3.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment for the whole pr.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done for whole PR.

Copy link
Contributor

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not creating the Gdrive directory and files within the e2e test?
E2E tests are written for other plugins in a way that the source / destination credentials can be changed and they should work. This dependency on existing Gdrive defeats that purpose.

@vikasrathee-cs vikasrathee-cs merged commit 4d3a7bd into develop Oct 16, 2025
5 checks passed
@vikasrathee-cs vikasrathee-cs deleted the driveE2E branch October 16, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants