-
Notifications
You must be signed in to change notification settings - Fork 12
google drive e2e tests #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
df2d108 to
e1b9ad1
Compare
| Feature: Google Drive Batch Source - Runtime Scenarios | ||
|
|
||
| @BATCH-TS-GD-MACRO-01 @BQ_SINK_TEST | ||
| Scenario: Validate successful records transfer from GoogleDrive to BigQuery with macro arguments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this scenario in cucumber reports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some new steps for macro feature. Now you will able to see in the report as well.
d53cbe2 to
fd69463
Compare
pom.xml
Outdated
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>2.18.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move version to properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
pom.xml
Outdated
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> | ||
| <artifactId>build-helper-maven-plugin</artifactId> | ||
| <version>3.3.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment for the whole pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done for whole PR.
itsankit-google
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we not creating the Gdrive directory and files within the e2e test?
E2E tests are written for other plugins in a way that the source / destination credentials can be changed and they should work. This dependency on existing Gdrive defeats that purpose.
This PR contains e2e test cases for google drive source plugin including locators, actions and stepdesigns classes.