Incorporate data from OpenStreetMap #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
Author
|
|
daohoangson
force-pushed
the
feature/osm
branch
from
9b5087d to
d0f9238
Compare
This was referenced Dec 30, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+10
to
+49
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0 | ||
| with: | ||
| submodules: recursive | ||
|
|
||
| - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0 | ||
| with: | ||
| go-version: ^1.21.0 | ||
| - run: go run ./downloader/03_osm.go ./downloader/osm | ||
|
|
||
| - name: Setup Bun | ||
| uses: oven-sh/setup-bun@a1800f471a0bc25cddac36bb13e6f436ddf341d7 # v1 | ||
| - name: Build demo/parser CLI | ||
| run: bun install && npm run bun:build | ||
| working-directory: demo/parser | ||
| - run: php transformers/osm/split.php | tee split.log | ||
|
|
||
| - name: Prepare GitHub comment | ||
| id: comment | ||
| run: printf 'BODY<<EOF\n%s\nEOF\n' "$(cat split.log)" >> $GITHUB_OUTPUT | ||
| - name: Post GitHub comment | ||
| uses: daohoangson/comment-on-github@35b21121fdbadf807678bec8210cdd7f22a934fe # v2.2.2 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| body: | | ||
| ${{ github.sha }} | ||
|
|
||
| ``` | ||
| ${{ steps.comment.outputs.BODY }} | ||
| ``` | ||
| fingerprint: "### Statistics" | ||
| replace: please | ||
|
|
||
| - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0 | ||
| with: | ||
| path: | | ||
| data/osm.csv | ||
| downloader/osm/working.json |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
This reverts commit 4761bbd.
Statistics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our GIS dataset is incomplete because the source only provides data up to level 2 entities. This PR aims to replace the official data source with OSM. The idea is to download the Vietnam file from
geofabrik.dethen map each OSM relation with an entity using our own parser module.Unfortunately, the OSM data appears to have some inconsistency, I'm submitting edits to OSM to rectify those https://www.openstreetmap.org/user/Dao%20Hoang%20Son/history
Working with the Vietnam OSM community to update data for this PR, in progress Google Docs at https://docs.google.com/spreadsheets/d/1ee0BJ_5YoERbxBPm3nTj82FuQsLOvBwsAgKGxA0QiDA/