Skip to content

Add ULID identifier #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roxblnfk merged 8 commits into from
Jul 15, 2025
Merged

Add ULID identifier #4

roxblnfk merged 8 commits into from
Jul 15, 2025

Conversation

@puzzledpolymath
Copy link
Contributor

@puzzledpolymath puzzledpolymath commented Jul 14, 2025

🔍 What was changed

  • Added new behavior for a universally unique lexicographically sortable identifier (ULID)
  • Added test cases covering ULID identifier
  • Added test cases for combining identifiers

📝 Checklist

  • How was this tested:
    • Unit tests added

@puzzledpolymath
Copy link
Contributor Author

puzzledpolymath commented Jul 14, 2025

I've tested locally, all working, 100% coverage etc however this will fail until cycle/entity-behavior#39 is released. I'll revisit this once that has been done.

@puzzledpolymath puzzledpolymath requested a review from a team July 15, 2025 00:06
@puzzledpolymath puzzledpolymath added the status:code review The pull request needs review. label Jul 15, 2025
@roxblnfk roxblnfk merged commit 53945f5 into 1.x Jul 15, 2025
16 checks passed
@roxblnfk roxblnfk changed the title Ulid identifer Add ULID identifier Jul 15, 2025
@roxblnfk roxblnfk deleted the ulid-identifer branch July 15, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

Assignees

No one assigned

Labels

status:code review The pull request needs review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@puzzledpolymath @roxblnfk