-
Notifications
You must be signed in to change notification settings - Fork 4
Add reusable <InputField>, <Select/>, <Textarea/> and <Checkbox/> components #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c60a88f to
075e960
Compare
✅ Deploy Preview for criipto-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
657adf8 to
075e960
Compare
075e960 to
d402926
Compare
Trinurt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! Getting there ☀️
4527335 to
ff007b3
Compare
jlndk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Looks really good!
The first commit, 91f470c, is a bit hard to review, since it does quite a lot. It would be nice if it could be split up (first introducing the code changes in one commit, and then a commit for each of the shared components).
Also, the comments I made on #274 also applies here
ff007b3 to
9271d88
Compare
9957602 to
05a820b
Compare
jlndk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!
Only minor comments
f6820c8 to
15323a0
Compare
|
QA: Authorize URL builder looks and works as expected (based a non-comprehensive test, trying a bunch of different inputs) |
jlndk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!!!
Huge upgrade to the visuals!
15323a0 to
b8e1cc8
Compare
- Update code styling in Tailwind Typography: remove default pseudo-element backticks (code::before / code::after). - Add global code styles with a smaller font size (will be used in form fields / support text).
To further align the documentation with the design system. The new <InputField>`s are implemented in Authorize URL builder.
To further align the documentation with the design system. Implemented in Authorize URL builder.
To further align the documentation with the design system. <Textarea> is implemented in Authorize URL builder.
b8e1cc8 to
f904dfc
Compare
To further align the documentation with the design system. <Checkbox> is implemented in Authorize URL builder.
f904dfc to
1303a77
Compare

To further align the documentation with the design system.
The new components are implemented in Authorize URL builder.
QA: Please review the new
<InputField>and<Select/>elements at https://deploy-preview-275--criipto-docs.netlify.app/verify/guides/authorize-url-builder/.