Skip to content

Conversation

@eisenwave
Copy link
Member

@eisenwave eisenwave commented Nov 9, 2025

Fixes #8454.

Fixes NB CA 041 (C++26 CD).
Fixes NB CA 092 (C++26 CD).
Fixes NB US 29-062 (C++26 CD).
Fixes NB US 35-066 (C++26 CD).
Fixes NB US 34-067 (C++26 CD).
Fixes NB US 60-110 (C++26 CD).
Fixes NB US 43-080 (C++26 CD).
Fixes NB US 15-032 (C++26 CD).
Fixes NB AT 4-099 (C++26 CD).
Fixes NB CA 045 (C++26 CD).
Fixes NB FR 155 (C++26 CD).

Also fixes cplusplus/CWG#546
Also fixes cplusplus/CWG#625
Also fixes https://github.com/cplusplus/nbballot/issues/616
Also fixes cplusplus/CWG#668
Also fixes cplusplus/CWG#681
Also fixes cplusplus/CWG#682
Also fixes cplusplus/CWG#685
Also fixes cplusplus/CWG#669
Also fixes https://github.com/cplusplus/nbballot/issues/669
Also fixes cplusplus/CWG#747
Also fixes cplusplus/CWG#751
Also fixes cplusplus/CWG#733
Also fixes cplusplus/CWG#756
Also fixes cplusplus/CWG#752
Also fixes cplusplus/CWG#750
Also fixes cplusplus/CWG#707
Also fixes cplusplus/CWG#759
Also fixes cplusplus/CWG#764
Also fixes cplusplus/CWG#761
Also fixes cplusplus/CWG#762
Also fixes cplusplus/CWG#767
Also fixes cplusplus/CWG#768
Also fixes cplusplus/CWG#769
Also fixes cplusplus/CWG#770
Also fixes cplusplus/CWG#755
Also fixes https://github.com/cplusplus/nbballot/issues/638
Also fixes https://github.com/cplusplus/nbballot/issues/642
Also fixes https://github.com/cplusplus/nbballot/issues/643
Also fixes https://github.com/cplusplus/nbballot/issues/688
Also fixes https://github.com/cplusplus/nbballot/issues/656
Also fixes https://github.com/cplusplus/nbballot/issues/607
Also fixes https://github.com/cplusplus/nbballot/issues/677
Also fixes https://github.com/cplusplus/nbballot/issues/620
Also fixes cplusplus/CWG#788
Also fixes cplusplus/CWG#780
Also fixes cplusplus/CWG#785
Also fixes cplusplus/CWG#786
Also fixes cplusplus/CWG#791
Also fixes https://github.com/cplusplus/nbballot/issues/734
Also fixes https://github.com/cplusplus/nbballot/issues/975
Also fixes https://github.com/cplusplus/nbballot/issues/602
Also fixes https://github.com/cplusplus/nbballot/issues/679

@eisenwave eisenwave added this to the post-2025-11 milestone Nov 9, 2025
@eisenwave eisenwave changed the title CWG2555 Ineffective redeclaration prevention for using-declarators P3921R0 DR issues Nov 9, 2025
@eisenwave eisenwave force-pushed the motions-2025-11-cwg-1 branch from ba92856 to ef2b72c Compare November 9, 2025 11:41
@eisenwave eisenwave marked this pull request as ready for review November 9, 2025 15:17
@eisenwave
Copy link
Member Author

@jensmaurer how does the referencing of editorial submissions and NB comments work on these types of PRs?

  • Should I add a Fixes cplusplus/CWG/... for each?
  • Should I add a Fixes cplusplus/nbballot/... for each closed NB comment?
  • Should I add a Fixes NB ... (C++26 CD). to the respective commit messages?

@jensmaurer
Copy link
Member

jensmaurer commented Nov 12, 2025

Should I add a Fixes NB ... (C++26 CD). to the respective commit messages?

Yes, please. We want a permanent record of those.

The "(Also) fixes" for /CWG/ and /nbballot/ goes into the pull request (initial comment) only, but please do add these (you did, apparently) so that when Thomas merges this, all related issues are auto-closed. This is github-level org only, so doesn't go into the commit message.

@jensmaurer
Copy link
Member

Please fix

! Undefined control sequence.
2025-11-09T15:18:20.7047350Z l.7572 followed by \tocde
2025-11-09T15:18:20.7047500Z                          {dt}, and

Also, please check why this has merge conflicts.

@frederick-vs-ja

This comment was marked as resolved.

@eisenwave eisenwave added the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 13, 2025
@tkoeppe tkoeppe changed the title P3921R0 DR issues CWG Poll 1: P3921R0 DR issues Nov 15, 2025
@eisenwave eisenwave force-pushed the motions-2025-11-cwg-1 branch from a87b471 to 5ac1488 Compare November 23, 2025 07:11
@eisenwave eisenwave removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 23, 2025
@eisenwave eisenwave requested a review from jensmaurer November 23, 2025 07:18
@eisenwave eisenwave requested a review from jensmaurer November 24, 2025 05:51
@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 13, 2025

@eisenwave I don't seem to have permissions to push into this PR branch. Would you be willing to change that, or shall I just move the branch elsewhere?

@eisenwave
Copy link
Member Author

Yeah sure, I don't know why you wouldn't have permission; I never uncheck the permission on these things.

@eisenwave
Copy link
Member Author

@tkoeppe I have invited you as a collaborator to both my forks. This should give you permission to make any change you want on all my PRs.

@tkoeppe tkoeppe force-pushed the motions-2025-11-cwg-1 branch from 3ce24ee to 47fa3cb Compare December 13, 2025 11:46
@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 13, 2025

Thanks, that works too!

…h indirection/address operators

Fixes NB US 267-401 (C++26 CD).

Editorial notes:
* [diff.expr] Use "example" environment as is our new style.
@tkoeppe tkoeppe force-pushed the motions-2025-11-cwg-1 branch from 47fa3cb to 90908ed Compare December 13, 2025 13:56
@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 13, 2025

I think CWG3001 is missing? I'll add it (but just to check that that's indeed the case).

Fixes NB US 43-080 (C++26 CD).
…dependent initializer

Fixes NB AT 4-099 (C++26 CD).
@tkoeppe tkoeppe force-pushed the motions-2025-11-cwg-1 branch from 90908ed to a091de6 Compare December 13, 2025 16:04
@eisenwave
Copy link
Member Author

I may have slipped up because CWG3101 is excluded. If CWG3001 is missing, that's simply an accident on my part.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 13, 2025

Yep, got it, thanks!

@tkoeppe tkoeppe force-pushed the motions-2025-11-cwg-1 branch from a091de6 to 5bfe790 Compare December 13, 2025 16:40
@tkoeppe tkoeppe merged commit cd27e1f into cplusplus:main Dec 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment