-
Notifications
You must be signed in to change notification settings - Fork 195
feat(kiali): Add Kiali with gevals #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
First approach @Cali0707 |
Cali0707
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aljesusg I left a comment on one of your tasks, but I think it applies across most of them having looked at more of the PR so far. In general, we support llm judge on responses where we expect the LLM to be giving us information/a summary of tool findings.
In terms of when to run kiali vs. the whole set of evals I defer to @manusa - what do you think Marc?
evals/tasks/kiali/troubleshooting-log/kiali-troubleshooting-log.yaml
Outdated
Show resolved
Hide resolved
I understand that this might be beneficial to run on PRs that affect the Kiali toolset, the filter sounds like a good approach. Additionally, we could improve the workflow dispatch to include a drop-down of the features/toolsets to test so at some point we can dispatch an execution for a given toolset evaluation. |
Signed-off-by: Alberto Gutierrez <[email protected]>
Signed-off-by: Alberto Gutierrez <[email protected]>
499d406 to
b0aa568
Compare
d6d2108 to
a7ee017
Compare
Signed-off-by: Alberto Gutierrez <[email protected]>
a7ee017 to
856c919
Compare
Kiali will run Gevals when the task filter is set to 'kiali'