switch opentelemetry span names for litestar from `/some/resource/123… #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` to `/some/resource/{resource_id}`
Contributor
|
It would be nice to see some tests. |
Contributor
|
I think this kind of stuff should be done in Litestar itself though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the base scenario open telemetry use scope.path as span.name param. But for endpoints with some id as a part of the route (for example
/some/resource/123) there will be a span for every resource_id. First of all, that will be a problem for analytic of your spans. But the second one, it will garbage your span collector with unlimited span names. That's why this PR switch opentelemetry span names for litestar from/some/resource/123to/some/resource/{resource_id}.