Skip to content

CRAFT-1978: add ToggleButton docs #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tylermorrisford merged 3 commits into from
Jan 6, 2026
Merged

CRAFT-1978: add ToggleButton docs #809

tylermorrisford merged 3 commits into from
Jan 6, 2026
+924 −3

Conversation

@tylermorrisford
Copy link
Contributor

@tylermorrisford tylermorrisford commented Dec 10, 2025

Adds engineering docs for ToggleButton.

@tylermorrisford tylermorrisford requested a review from a team December 10, 2025 15:54
@tylermorrisford tylermorrisford self-assigned this Dec 10, 2025
@tylermorrisford tylermorrisford requested review from ByronDWall, ddouglasz, jaikamat, misama-ct, stephsprinkle and valoriecarli and removed request for a team December 10, 2025 15:54
@tylermorrisford tylermorrisford added the documentation Improvements or additions to documentation label Dec 10, 2025
@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9eef09a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nimbus-documentation Ready Ready Preview, Comment Jan 6, 2026 3:05pm
nimbus-storybook Ready Ready Preview, Comment Jan 6, 2026 3:05pm

stephsprinkle
stephsprinkle approved these changes Dec 16, 2025
View reviewed changes
packages/nimbus/src/components/toggle-button/toggle-button.dev.mdx

### Accessibility

The ToggleButton component is built on React Aria's ToggleButton, which provides robust accessibility features out of the box.
Copy link
Contributor

@stephsprinkle stephsprinkle Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most components have the same blurb around accessibility, wondering if this applies here

Image

Copy link
Contributor Author

@tylermorrisford tylermorrisford Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 214 does this (for me) by outlining the case where an icon-only button is used.

misama-ct
misama-ct approved these changes Jan 6, 2026
View reviewed changes
Copy link
Collaborator

@misama-ct misama-ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

packages/nimbus/src/components/toggle-button/toggle-button.dev.mdx
@@ -0,0 +1,465 @@
---
title: ToggleButton Component
Copy link
Collaborator

@misama-ct misama-ct Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had trouble finding the component via the Search, it was only showing the ToggleButtonGroup, then I noticed the regular mdx-file still uses Toggle Button instead of ToggleButton as title, you mind changing it as well?

@tylermorrisford tylermorrisford merged commit 9a4ea87 into main Jan 6, 2026
6 of 8 checks passed
@tylermorrisford tylermorrisford deleted the CRAFT-1978-togglebutton branch January 6, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephsprinkle stephsprinkle stephsprinkle approved these changes

@misama-ct misama-ct misama-ct approved these changes

@jaikamat jaikamat Awaiting requested review from jaikamat jaikamat was automatically assigned from commercetools/craft-team-fe-tag-all

@ddouglasz ddouglasz Awaiting requested review from ddouglasz ddouglasz was automatically assigned from commercetools/craft-team-fe-tag-all

@valoriecarli valoriecarli Awaiting requested review from valoriecarli valoriecarli was automatically assigned from commercetools/craft-team-fe-tag-all

@ByronDWall ByronDWall Awaiting requested review from ByronDWall ByronDWall was automatically assigned from commercetools/craft-team-fe-tag-all

Assignees

@tylermorrisford tylermorrisford

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tylermorrisford @stephsprinkle @misama-ct