Skip to content

WIP: Field validation #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
JeffersonBledsoe wants to merge 97 commits into
base: main
Choose a base branch
from
Draft

WIP: Field validation #40

JeffersonBledsoe wants to merge 97 commits into from

Conversation

@JeffersonBledsoe
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe commented Dec 12, 2023 •
edited
Loading

This PR builds upon #37 To add support for validating fields. An optional install for Products.validation is added and the validators in here can be used to validate a field from a submission

Todo

  • Add some additional validators not found in Products.validation, such as "min length" and "max length" to cover existing validations that are covered by volto-form-block
  • Fix saving of settings. The deserializer for the frontend works well, but we need a serializer to convert back to something the validation objects support and update the objects themselves.
  • Tests

@JeffersonBledsoe
Add class for 'Fields' to simplify custom logic and use it for filter…
c458ee2 
…_parameters
@JeffersonBledsoe
Fix non-required fields
d6aa386
@JeffersonBledsoe
Fix reading incorrect internal value
17697d8
@JeffersonBledsoe
Fix values not displayign
b9bb05f
@JeffersonBledsoe
Use @Property for 'value'
3c45a3a
@JeffersonBledsoe
Fix some existing behaviours
70a17f1
@JeffersonBledsoe
Add test for custom_field_id
9bf7879
@JeffersonBledsoe
Fix custom field ID
624170d
@JeffersonBledsoe
Fix inconsistent use of field_id in requess
3ea20ae
@JeffersonBledsoe
Restore support for falling back to field_id if label doesn't exist
b3ca7da
@JeffersonBledsoe
Fix data storing
e821e3f
@JeffersonBledsoe
Fix custom_field_id in data export
cd8e9bb
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
bd40e5c
@JeffersonBledsoe
Add tests for display values
e1994e0
@JeffersonBledsoe
Fix catalog using display value for storage
b5c75da
@JeffersonBledsoe
Fix XML using external value
f2ff588
@JeffersonBledsoe
Update frontend field name
2cf29d3
@JeffersonBledsoe
Test fix
810d675
@JeffersonBledsoe
Initial validation support
9a76a5c
@JeffersonBledsoe
Fix HTTP response code
c184b55
@JeffersonBledsoe
Fix crash when no validations are set
bd1e2d0
@JeffersonBledsoe
Readme
5524684
@JeffersonBledsoe
Typo fix
ac749fb
@JeffersonBledsoe
Initial serializer for validation settings
8df42f5
@JeffersonBledsoe
Add "ignore" to list of internal ignored fields
94cd023
@JeffersonBledsoe
Fix serializer deleting the actual validation object's settings
97b1815
@JeffersonBledsoe
Fix IPloneSiteRoot import
ff79791
@JeffersonBledsoe
Fix validations not occurign
2dcd6fb
@JeffersonBledsoe
Able to return nice error messages
afc6b7d
@JeffersonBledsoe
WIP: Custom validation
83ad017
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
c4f8110 
# Conflicts:
#	src/collective/volto/formsupport/restapi/services/submit_form/post.py
#	src/collective/volto/formsupport/tests/test_send_action_form.py
@JeffersonBledsoe
Fix missing import from test
4b2a872
@JeffersonBledsoe
Fix test being incorrect
aa3c786
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
49f7df8
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
6fd8d93 
# Conflicts:
#	src/collective/volto/formsupport/restapi/services/submit_form/post.py
@JeffersonBledsoe
Cleanup bad merge
a26d13c
@JeffersonBledsoe
Fix missing use of fields from bad merge
9b64a9d
@JeffersonBledsoe
Update outdated status codes
81d9174
@JeffersonBledsoe
lint
a08bf7b
@JeffersonBledsoe
Wrong code updated....
b5936dd
@JeffersonBledsoe
Fix test for custom display value
f7b62ff
@JeffersonBledsoe
Fix cleanup of custom_field_id
e716145
@JeffersonBledsoe
Update test for send action form to match actual data
c806b31
@JeffersonBledsoe
lint
85a869b
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
d6ba9ea 
# Conflicts:
#	src/collective/volto/formsupport/tests/test_send_action_form.py
@JeffersonBledsoe
Use field class for date formatting
a094d68
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
3aadeda 
# Conflicts:
#	src/collective/volto/formsupport/restapi/services/submit_form/post.py
#	src/collective/volto/formsupport/tests/test_send_action_form.py
@JeffersonBledsoe
lint
7d2cfcc
@JeffersonBledsoe
Use field class where possible
f8787cd
@JeffersonBledsoe
Fix sending attachments on accident
aa62f3c
@JeffersonBledsoe
Compute fields when they're needed so that events can still modify th…
b258131 
…e data
@JeffersonBledsoe
Handle not installing the validations library correctly
bb953ba
@JeffersonBledsoe
Gracefully support for when Products.validations isn't installed but …
160b769 
…the frontend might expect it to be
@JeffersonBledsoe
Remove a debug statement causing the vocab to hang 😔
9a835b4
@JeffersonBledsoe
Merge branch 'pretagov-main' into field-validation
521702c 
# Conflicts:
#	setup.py
#	src/collective/volto/formsupport/configure.zcml
#	src/collective/volto/formsupport/restapi/deserializer/configure.zcml
#	src/collective/volto/formsupport/restapi/serializer/blocks.py
#	src/collective/volto/formsupport/restapi/services/submit_form/post.py
#	src/collective/volto/formsupport/tests/test_send_action_form.py
#	src/collective/volto/formsupport/tests/test_store_action_form.py
@JeffersonBledsoe
Fix missing class from bad merge
b84a277
@JeffersonBledsoe
Merge branch 'pretagov-main' into custom-label-mapping
c6749e3 
# Conflicts:
#	src/collective/volto/formsupport/adapters/post.py
@JeffersonBledsoe
Merge branch 'custom-label-mapping' into field-validation
d954659 
# Conflicts:
#	src/collective/volto/formsupport/restapi/services/submit_form/field.py
#	src/collective/volto/formsupport/restapi/services/submit_form/post.py
#	src/collective/volto/formsupport/tests/test_send_action_form.py
#	src/collective/volto/formsupport/tests/test_store_action_form.py
@JeffersonBledsoe
Try to fix validations
e62a4f1
@JeffersonBledsoe
Fix error handling
ad269a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JeffersonBledsoe