Skip to content

Fix SpotBugs warnings: remove double-check, make inner classes static, dedupe switch clauses, and tighten quality gates #4413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shai-almog merged 5 commits into from
Jan 14, 2026
Merged

Fix SpotBugs warnings: remove double-check, make inner classes static, dedupe switch clauses, and tighten quality gates #4413

shai-almog merged 5 commits into from
Jan 14, 2026
+123 −150

Conversation

@shai-almog
Copy link
Collaborator

@shai-almog shai-almog commented Jan 14, 2026

Motivation

  • Eliminate SpotBugs "Possible double-check" warnings by replacing fragile double-checked locking with safer lazy-init patterns.
  • Remove "The class could be refactored into a static inner class" warnings by making helper inner classes static and wiring required context explicitly.
  • Remove duplicate-switch-clause warnings by consolidating repeated switch logic into a single path.
  • Enforce the new SpotBugs rules in the PR quality check by updating generate-quality-report.py to treat the relevant rules as build failures.

Description

  • Replaced double-checked locking with synchronized initialization or holder/factory methods for InputComponent.isGuiBuilderMode(), TextField.initInputModes(), Transform.IDENTITY(), CSSBorder.styleMap(), StyleParser.bgTypes(), and Validator.initDefaultValidationFailedEmblem().
  • Converted several inner classes to static and passed explicit owner/context where needed: BrowserWindow.BrowserForm, Slider.SliderActionEvent, Toolbar.CallbackSearchBar, and MorphTransition.CC.
  • Consolidated duplicated switch logic in SeriesTransition.initTransition() by setting a linear motion default and switching only for non-linear easing options.
  • Simplified vertical-alignment drawing in DefaultLookAndFeel.drawLabelImageValign() to compute the Y once and draw once.
  • Merged duplicated case handling in Resources.openFileImpl() by combining MAGIC_DATA and MAGIC_UI cases to call createData() once.
  • Replaced lazy-initialized maps with create* factory initializers and static finals in CSSBorder and StyleParser.
  • Updated .github/scripts/generate-quality-report.py to add DC_DOUBLECHECK, DB_DUPLICATE_SWITCH_CLAUSES, and SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS to the set of SpotBugs rules that cause the PR CI to fail.

Testing

  • No automated unit tests or CI runs were executed as part of this change.
  • Static changes were limited to refactoring and preserving existing semantics, and no behavioral changes were intended.
  • The code was compiled/inspected locally (no test execution) to ensure the modified methods and constructors match existing call sites.
  • The SpotBugs rule list was updated so future CI runs will fail if these classes regress.

Codex Task

@github-actions
Copy link

github-actions bot commented Jan 14, 2026 •
edited
Loading

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Generated automatically by the PR CI workflow.

@shai-almog
Copy link
Collaborator Author

shai-almog commented Jan 14, 2026 •
edited
Loading

iOS screenshot updates

Compared 30 screenshots: 22 matched, 7 updated, 1 missing reference.

  • BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    BrowserComponent
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

  • graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-arc
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

  • graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-gradient
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

  • graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

    graphics-draw-round-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

  • graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-string
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
    Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

  • graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-string-decorated
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

  • graphics-fill-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-fill-arc
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-arc.png in workflow artifacts.

  • kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    kotlin
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

  • VM Translation Time: 362 seconds
  • Compilation Time: 80 seconds

Detailed Performance Metrics

Metric Duration
Build Time Statistics
Setup & Unzip 31989 ms
Extract Extensions 18 ms
Google Services Setup 2 ms
Scan Classes 1508 ms
Extract Libs 1247 ms
Inject Build Hints 50 ms
Generate Unit Tests 3 ms
Generate Stubs 1448 ms
Compile Stubs 3175 ms
Generate Icons 2135 ms
Prepare ParparVM 301 ms
ParparVM Execution 202386 ms
Post-VM Setup 218 ms
CocoaPods 5400 ms
Finalize 27 ms
Total Time 249908 msMaven Overhead : 113000 ms
CocoaPods Install (Script) 2000 ms
Simulator Boot (Run) 158000 ms
App Install 14000 ms
App Launch 6000 ms
Test Execution 194000 ms

@shai-almog
Copy link
Collaborator Author

shai-almog commented Jan 14, 2026 •
edited
Loading

Compared 30 screenshots: 30 matched.

Native Android coverage

  • 📊 Line coverage: 25.41% (2723/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 25.07% (12668/50528), branch 15.90% (743/4672), complexity 17.92% (760/4241), method 33.74% (614/1820), class 36.30% (110/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

  • 📊 Line coverage: 25.41% (2723/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 25.07% (12668/50528), branch 15.90% (743/4672), complexity 17.92% (760/4241), method 33.74% (614/1820), class 36.30% (110/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

@shai-almog shai-almog merged commit 9f9c22b into master Jan 14, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shai-almog