Skip to content

Conversation

@joseph-sentry
Copy link
Contributor

we remove the old CAs that are no longer being used in the GQL api since
we’re using the new ones exclusively

the hourly CAs are just used as a “bridge” to the daily CAs so we do
some intermediary deduplication within the hour, just so we amortize the
cost of aggregation a bit more throughout the day, so we don’t have to
retain them for long

we don’t need to cache rollups in the new pipeline anymore since the API
is consuming from timescale directly

So we’re removing all code related to caching rollups in the timescale
implementation of the TA pipeline

@joseph-sentry joseph-sentry requested a review from a team as a code owner August 29, 2025 16:46
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 29, 2025

CodSpeed Performance Report

Merging #444 will not alter performance

Comparing finish-ts-rollout (6cd56a2) with main (9fd51a5)1

Summary

✅ 9 untouched benchmarks

Footnotes

  1. No successful run was found on main (9676acc) during the generation of this report, so 9fd51a5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.24%. Comparing base (9676acc) to head (6cd56a2).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
+ Coverage   94.14%   94.24%   +0.09%     
==========================================
  Files        1276     1277       +1     
  Lines       47221    47089     -132     
  Branches     1509     1509              
==========================================
- Hits        44458    44380      -78     
+ Misses       2456     2402      -54     
  Partials      307      307              
Flag Coverage Δ
apiunit 96.42% <100.00%> (+0.20%) ⬆️
sharedintegration 39.65% <0.00%> (-0.24%) ⬇️
sharedunit 88.80% <100.00%> (-0.01%) ⬇️
workerintegration 60.59% <100.00%> (-0.09%) ⬇️
workerunit 90.80% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ElioDiNino ElioDiNino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely cleanup 🧹

@joseph-sentry joseph-sentry force-pushed the finish-ts-rollout branch 3 times, most recently from 1861d44 to 8e116aa Compare September 2, 2025 16:06
@joseph-sentry joseph-sentry force-pushed the finish-ts-rollout branch 2 times, most recently from 7af87b1 to 25bf7a3 Compare September 2, 2025 16:27
we remove the old CAs that are no longer being used in the GQL api since
we’re using the new ones exclusively

the hourly CAs are just used as a “bridge” to the daily CAs so we do 
some intermediary deduplication within the hour, just so we amortize the
cost of aggregation a bit more throughout the day, so we don’t have to 
retain them for long
we don’t need to cache rollups in the new pipeline anymore since the API
is consuming from timescale directly

So we’re removing all code related to caching rollups in the timescale 
implementation of the TA pipeline
@joseph-sentry joseph-sentry added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit 5829bc8 Sep 2, 2025
87 of 89 checks passed
@joseph-sentry joseph-sentry deleted the finish-ts-rollout branch September 2, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants