Skip to content

Conversation

@joseph-sentry
Copy link
Contributor

the "commits failed” field on the CAs previously failed to deduplicate
commits that failed across days so if commit A failed yesterday and
today it would count for 2 commits failed, the new CAs fix this so we
want to consume information from them instead of the old ones.

This commit also reorganizes the timescale aggregation code in the GQL
API and checks the is_called_from_sentry_app function to decide which
version of the aggregation to use

@joseph-sentry joseph-sentry requested a review from a team as a code owner August 29, 2025 16:45
@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 79.52381% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.14%. Comparing base (fdac18c) to head (b395f9f).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/shared/shared/django_apps/migration_utils.py 26.47% 24 Missing and 1 partial ⚠️
apps/codecov-api/utils/timescale/test_results.py 77.35% 12 Missing ⚠️
...pps/codecov-api/utils/timescale/timescale_utils.py 90.32% 3 Missing ⚠️
...ps/codecov-api/utils/timescale/flake_aggregates.py 91.66% 2 Missing ⚠️
...pps/codecov-api/utils/timescale/test_aggregates.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
- Coverage   94.17%   94.14%   -0.04%     
==========================================
  Files        1272     1276       +4     
  Lines       47180    47221      +41     
  Branches     1507     1509       +2     
==========================================
+ Hits        44434    44458      +24     
- Misses       2440     2456      +16     
- Partials      306      307       +1     
Flag Coverage Δ
apiunit 96.22% <89.77%> (+0.04%) ⬆️
sharedintegration 39.88% <17.64%> (-0.06%) ⬇️
sharedunit 88.81% <26.47%> (-0.16%) ⬇️
workerintegration 60.67% <ø> (ø)
workerunit 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 29, 2025

CodSpeed Performance Report

Merging #443 will not alter performance

Comparing use-new-cas (b395f9f) with main (9fd51a5)

Summary

✅ 9 untouched benchmarks

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 79.52381% with 43 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/shared/shared/django_apps/migration_utils.py 26.47% 24 Missing and 1 partial ⚠️
apps/codecov-api/utils/timescale/test_results.py 77.35% 12 Missing ⚠️
...pps/codecov-api/utils/timescale/timescale_utils.py 90.32% 3 Missing ⚠️
...ps/codecov-api/utils/timescale/flake_aggregates.py 91.66% 2 Missing ⚠️
...pps/codecov-api/utils/timescale/test_aggregates.py 96.29% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (79.52%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

we create a function to allow to run a timescale index creation with 
transaction per chunk and modify the django state at the same time


we also create functions for removing the retention policy on a CA and 
create a TTL per row retention policy for a hypertable and for a CA
the "commits failed” field on the CAs previously failed to deduplicate 
commits that failed across days so if commit A failed yesterday and 
today it would count for 2 commits failed, the new CAs fix this so we 
want to consume information from them instead of the old ones.

This commit also reorganizes the timescale aggregation code in the GQL 
API and checks the is_called_from_sentry_app function to decide which 
version of the aggregation to use
@joseph-sentry joseph-sentry added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit 9676acc Sep 2, 2025
83 of 87 checks passed
@joseph-sentry joseph-sentry deleted the use-new-cas branch September 2, 2025 15:52
@sentry
Copy link

sentry bot commented Sep 3, 2025

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants