Skip to content

Conversation

@zhamborova
Copy link
Contributor

No description provided.

@zhamborova zhamborova requested a review from Copilot April 7, 2025 11:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 29 out of 31 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • tools/test/eslint/.eslintrc.json: Language not supported
  • tools/test/eslint/config.json: Language not supported
Comments suppressed due to low confidence (3)

tools/test/eslint/test.js:1

  • [nitpick] The variable name 'foo' is ambiguous and may reduce clarity in tests. Consider using a more descriptive name if the test logic becomes more complex.
var foo = "bar"

tools/pmd/pmdConfigCreator.go:11

  • Ensure that the embedded file path 'default-ruleset.xml' is correct relative to this file after the package restructuring. An incorrect path may cause the default ruleset to fail to load.
//go:embed default-ruleset.xml

cmd/analyze.go:198

  • This TODO comment indicates that the config file parameter is not yet handled. Either implement support for passing the config file or remove the comment and document why an empty parameter is acceptable.
//todo pass config file

@codacy-production
Copy link

codacy-production bot commented Apr 7, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% 33.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5b319ed) 2200 589 26.77%
Head commit (d6678cf) 2204 (+4) 591 (+2) 26.81% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#57) 24 8 33.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@zhamborova zhamborova marked this pull request as ready for review April 7, 2025 11:49
@zhamborova zhamborova changed the title Restructure Restructure tools folder Apr 7, 2025
@zhamborova zhamborova requested a review from Copilot April 7, 2025 11:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • tools/test/eslint/config.json: Language not supported
Comments suppressed due to low confidence (1)

cmd/analyze.go:198

  • Address the TODO comment by either implementing the functionality to pass the configuration file for ESLint or referencing an issue for future work to avoid ambiguity in analysis behavior.
//todo pass config file


// Read expected ruleset
expectedRulesetPath := filepath.Join("testdata", "repositories", "pmd", "expected-ruleset.xml")
expectedRulesetPath := "expected-ruleset.xml"
Copy link

Copilot AI Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the expected ruleset file path is correct relative to the test execution directory. If the file is located in a subdirectory, consider using a dynamic file path construction similar to filepath.Join.

Suggested change
expectedRulesetPath := "expected-ruleset.xml"
expectedRulesetPath := filepath.Join("tools", "test", "pmd", "expected-ruleset.xml")

Copilot uses AI. Check for mistakes.
@andrzej-janczak andrzej-janczak marked this pull request as draft April 9, 2025 13:46
@zhamborova zhamborova closed this May 11, 2025
@zhamborova zhamborova deleted the restructure branch May 11, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants