-
Notifications
You must be signed in to change notification settings - Fork 11
[PLUTO-1359] Add pylint tool #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the pylint tool by introducing SARIF conversion for pylint’s JSON output, a dedicated pylint runner, and updated configurations for tool installation and analysis.
- Added a new SARIF conversion utility in utils/sarif.go
- Introduced a new pylint runner in tools/pylintRunner.go and integrated it into the CLI commands
- Updated various configuration files to support the pylint tool and its runtime requirements
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| utils/sarif.go | Adds SARIF conversion functionality for pylint output |
| tools/pylintRunner.go | Implements execution of pylint with JSON/SARIF support |
| plugins/tools/pylint/plugin.yaml | Adds configuration file for pylint |
| plugins/runtimes/python/plugin.yaml | Updates python binary paths |
| plugins/runtime-utils.go | Adjusts installation directory logic for Python runtime |
| config/tools-installer.go | Introduces separate installation logic for Python tools |
| cmd/init.go | Adds pylint version to configuration |
| cmd/analyze.go | Integrates pylint analysis into CLI command handling |
| func (p *runtimePlugin) getInstallationDirectoryPath(runtimesDir string, version string) string { | ||
| // For Python, we want to use a simpler directory structure | ||
| if p.Config.Name == "python" { | ||
| return path.Join(runtimesDir, "python") |
Copilot
AI
Apr 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For cross-platform compatibility, consider using filepath.Join instead of path.Join when constructing filesystem paths.
| return path.Join(runtimesDir, "python") | |
| return filepath.Join(runtimesDir, "python") |
andrzej-janczak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.