Skip to content

Conversation

@zhamborova
Copy link
Contributor

No description provided.

@codacy-production
Copy link

codacy-production bot commented Apr 1, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-3.08% 1.06%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fbcf3b3) 1562 459 29.39%
Head commit (95b990c) 1749 (+187) 460 (+1) 26.30% (-3.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#49) 189 2 1.06%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@zhamborova zhamborova marked this pull request as ready for review April 1, 2025 15:09
@andrzej-janczak andrzej-janczak requested a review from Copilot April 1, 2025 15:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the pylint tool by introducing SARIF conversion for pylint’s JSON output, a dedicated pylint runner, and updated configurations for tool installation and analysis.

  • Added a new SARIF conversion utility in utils/sarif.go
  • Introduced a new pylint runner in tools/pylintRunner.go and integrated it into the CLI commands
  • Updated various configuration files to support the pylint tool and its runtime requirements

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
utils/sarif.go Adds SARIF conversion functionality for pylint output
tools/pylintRunner.go Implements execution of pylint with JSON/SARIF support
plugins/tools/pylint/plugin.yaml Adds configuration file for pylint
plugins/runtimes/python/plugin.yaml Updates python binary paths
plugins/runtime-utils.go Adjusts installation directory logic for Python runtime
config/tools-installer.go Introduces separate installation logic for Python tools
cmd/init.go Adds pylint version to configuration
cmd/analyze.go Integrates pylint analysis into CLI command handling

func (p *runtimePlugin) getInstallationDirectoryPath(runtimesDir string, version string) string {
// For Python, we want to use a simpler directory structure
if p.Config.Name == "python" {
return path.Join(runtimesDir, "python")
Copy link

Copilot AI Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cross-platform compatibility, consider using filepath.Join instead of path.Join when constructing filesystem paths.

Suggested change
return path.Join(runtimesDir, "python")
return filepath.Join(runtimesDir, "python")

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@andrzej-janczak andrzej-janczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhamborova zhamborova merged commit 557ff3d into main Apr 2, 2025
8 checks passed
@zhamborova zhamborova deleted the pylint_tool branch April 23, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants