Fix: version passing to GoReleaser configuration #115
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,16 +59,22 @@ | |
| - name: "Git Version" | ||
| id: generate-version | ||
| uses: codacy/[email protected] | ||
| with: | ||
| release-branch: main | ||
| prefix: v | ||
| - name: "Tag version" | ||
| run: | | ||
| git tag ${{ steps.generate-version.outputs.version }} | ||
| git push --tags "https://codacy:${{ secrets.GITHUB_TOKEN }}@github.com/codacy/codacy-cli-v2" | ||
| - name: Get Go version | ||
| id: go-version | ||
|
Check warning on line 70 in .github/workflows/go.yml
|
||
| run: echo "VERSION=$(go version | cut -d' ' -f3)" >> $GITHUB_OUTPUT | ||
| - name: Run GoReleaser | ||
| uses: goreleaser/goreleaser-action@v5 | ||
| with: | ||
| distribution: goreleaser | ||
| version: "~> v1" | ||
| args: release --clean | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GOVERSION: ${{ steps.go-version.outputs.VERSION }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| project_name: codacy-cli-v2 | ||
|
|
||
| before: | ||
| hooks: | ||
| - go mod tidy | ||
|
|
||
| builds: | ||
| - env: | ||
| - CGO_ENABLED=0 | ||
| goos: | ||
| - linux | ||
| - windows | ||
| - darwin | ||
| goarch: | ||
| - amd64 | ||
| - arm64 | ||
| ldflags: | ||
| - -s -w | ||
| - -X codacy/cli-v2/version.Version={{.Version}} | ||
| - -X codacy/cli-v2/version.GitCommit={{.ShortCommit}} | ||
| - -X codacy/cli-v2/version.BuildTime={{.Date}} | ||
| - -X codacy/cli-v2/version.Os={{.Os}} | ||
| - -X codacy/cli-v2/version.Arch={{.Arch}} | ||
| - -X codacy/cli-v2/version.GoVersion={{.Env.GOVERSION}} | ||
| binary: cli-v2 | ||
|
|
||
| archives: | ||
| - format: tar.gz | ||
| name_template: >- | ||
| {{ .ProjectName }}_ | ||
| {{- .Version }}_ | ||
| {{- .Os }}_ | ||
| {{- .Arch }} | ||
| format_overrides: | ||
| - goos: windows | ||
| format: zip | ||
|
|
||
| changelog: | ||
| sort: asc | ||
| filters: | ||
| exclude: | ||
| - '^docs:' | ||
| - '^test:' | ||
| - '^ci:' | ||
| - Merge pull request | ||
| - Merge branch | ||
|
|
||
| release: | ||
| github: | ||
| owner: codacy | ||
| name: codacy-cli-v2 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
his change to version: "~> v1" means:
You'll always get the latest v1.x.x release
You're protected from breaking changes that might come in v2.0.0
You'll automatically get bug fixes and minor improvements within the v1 series
It's more flexible than pinning to a specific version while still maintaining stability
This is what the warning was suggesting as a best practice, and it's a better approach than either using latest (too loose) or a specific version like v1.21.1 (too strict).