Skip to content

Conversation

@elrrrrrrr
Copy link
Member

@elrrrrrrr elrrrrrrr commented Apr 27, 2025

  • 🐳 Implement Docker-based builds (ubuntu:20.04) to fix glibc-related linkage problems

Summary by CodeRabbit

  • Chores
    • Updated CI and release workflows to use the latest available Ubuntu runner for improved consistency and future compatibility.
    • The Linux binding release process now runs in a containerized environment with explicit dependency and Rust toolchain installation.
    • Removed unnecessary use of sudo in package installations within the containerized workflow.

@elrrrrrrr elrrrrrrr added the documentation Improvements or additions to documentation label Apr 27, 2025
@elrrrrrrr elrrrrrrr requested a review from killagu April 27, 2025 03:39
@coderabbitai
Copy link

coderabbitai bot commented Apr 27, 2025

Walkthrough

The changes update GitHub Actions workflow files to standardize the Linux runner environment from the fixed version ubuntu-22.04 to the more generic ubuntu-latest. Additionally, the linux-binding-release job in the release workflow is now containerized using the ubuntu:20.04 Docker image, with explicit steps for installing dependencies and setting up Rust. Usage of sudo in package installation is removed within the containerized environment. No changes were made to public APIs or exported entities.

Changes

Files/Paths Change Summary
.github/workflows/ci.yml,
.github/workflows/rust-test.yml
Updated Linux jobs to use ubuntu-latest instead of ubuntu-22.04 for the runner OS.
.github/workflows/release.yml Updated Linux jobs to use ubuntu-latest runner; containerized linux-binding-release job with ubuntu:20.04 Docker image, added explicit dependency and Rust installation, removed sudo in package installation.

Poem

A hop, a skip, the runners change,
Ubuntu-latest, now in range!
Containers spin, dependencies flow,
Rust installs with a steady glow.
No more sudo in the bashy den,
Workflows modern, once again!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
.github/workflows/release.yml (3)

20-24: Containerize linux-binding-release on Ubuntu 20.04
Running this job inside an ubuntu:20.04 Docker container isolates glibc versions and addresses the linkage issues you encountered. Consider pinning the container image to a specific digest (e.g., ubuntu:20.04@sha256:…) to avoid unexpected upstream changes.


30-47: Optimize Linux dependencies installation
This step installs many packages in one go. You might:

  • Combine apt-get update and install into a single layer for faster builds.
  • Add --no-install-recommends to reduce image size.
  • Verify that all required headers and tools are covered by these packages.

76-78: Remove duplicate package installations
The second “Install” step reinstalls libssl-dev, libpango1.0-dev, and gcc-aarch64-linux-gnu (already installed earlier) and adds sudo (unneeded in a root container). Consolidate these into your initial dependency step to streamline the workflow.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52716a3 and 64a976a.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml (2 hunks)
  • .github/workflows/release.yml (5 hunks)
  • .github/workflows/rust-test.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/release.yml

49-49: the runner of "actions-rs/toolchain@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: linux-test (16.x, ubuntu-latest, bash, 3.9)
  • GitHub Check: linux-test (20.x, ubuntu-latest, bash, 3.9)
  • GitHub Check: macos-test (20.x, bash)
  • GitHub Check: linux-test (18.x, ubuntu-latest, bash, 3.9)
  • GitHub Check: macos-test (18.x, bash)
  • GitHub Check: macos-test (16.x, bash)
  • GitHub Check: linux-ci (20.x, ubuntu-latest, bash)
  • GitHub Check: linux-ci (16.x, ubuntu-latest, bash)
  • GitHub Check: linux-ci (18.x, ubuntu-latest, bash)
  • GitHub Check: build (ubuntu-latest, bash)
🔇 Additional comments (6)
.github/workflows/ci.yml (2)

23-24: Standardize runner OS to ubuntu-latest
Replacing the previous fixed Ubuntu version with ubuntu-latest aligns this job with other workflows and ensures you benefit from the most recent security and performance updates.


89-90: Standardize runner OS to ubuntu-latest
The same update in the linux-test job maintains consistency across your CI matrix.

.github/workflows/rust-test.yml (1)

22-23: Standardize runner OS to ubuntu-latest
Updating the build job to run on ubuntu-latest keeps it in sync with other workflows and benefits from ongoing maintenance of the runner image.

.github/workflows/release.yml (3)

205-206: Standardize runner OS for binding-pkg-release
Switching this job to ubuntu-latest runner matches the rest of your release pipeline. Double-check that native glibc compatibility is acceptable here.


265-266: Standardize runner OS for lib-release
Updated to ubuntu-latest for consistency with the other release jobs.


321-322: Standardize runner OS for final release job
Using ubuntu-latest here completes the alignment of all Linux-based jobs in your pipeline.

@elrrrrrrr elrrrrrrr merged commit 71e0652 into master Apr 27, 2025
13 checks passed
@elrrrrrrr elrrrrrrr deleted the docker-build branch April 27, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants