-
Notifications
You must be signed in to change notification settings - Fork 5
chore: ubuntu-20.04 docker #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update GitHub Actions workflow files to standardize the Linux runner environment from the fixed version Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
.github/workflows/release.yml (3)
20-24: Containerizelinux-binding-releaseon Ubuntu 20.04
Running this job inside anubuntu:20.04Docker container isolates glibc versions and addresses the linkage issues you encountered. Consider pinning the container image to a specific digest (e.g.,ubuntu:20.04@sha256:…) to avoid unexpected upstream changes.
30-47: Optimize Linux dependencies installation
This step installs many packages in one go. You might:
- Combine
apt-get updateandinstallinto a single layer for faster builds.- Add
--no-install-recommendsto reduce image size.- Verify that all required headers and tools are covered by these packages.
76-78: Remove duplicate package installations
The second “Install” step reinstallslibssl-dev,libpango1.0-dev, andgcc-aarch64-linux-gnu(already installed earlier) and addssudo(unneeded in a root container). Consolidate these into your initial dependency step to streamline the workflow.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/ci.yml(2 hunks).github/workflows/release.yml(5 hunks).github/workflows/rust-test.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/release.yml
49-49: the runner of "actions-rs/toolchain@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: linux-test (16.x, ubuntu-latest, bash, 3.9)
- GitHub Check: linux-test (20.x, ubuntu-latest, bash, 3.9)
- GitHub Check: macos-test (20.x, bash)
- GitHub Check: linux-test (18.x, ubuntu-latest, bash, 3.9)
- GitHub Check: macos-test (18.x, bash)
- GitHub Check: macos-test (16.x, bash)
- GitHub Check: linux-ci (20.x, ubuntu-latest, bash)
- GitHub Check: linux-ci (16.x, ubuntu-latest, bash)
- GitHub Check: linux-ci (18.x, ubuntu-latest, bash)
- GitHub Check: build (ubuntu-latest, bash)
🔇 Additional comments (6)
.github/workflows/ci.yml (2)
23-24: Standardize runner OS to ubuntu-latest
Replacing the previous fixed Ubuntu version withubuntu-latestaligns this job with other workflows and ensures you benefit from the most recent security and performance updates.
89-90: Standardize runner OS to ubuntu-latest
The same update in thelinux-testjob maintains consistency across your CI matrix..github/workflows/rust-test.yml (1)
22-23: Standardize runner OS to ubuntu-latest
Updating thebuildjob to run onubuntu-latestkeeps it in sync with other workflows and benefits from ongoing maintenance of the runner image..github/workflows/release.yml (3)
205-206: Standardize runner OS forbinding-pkg-release
Switching this job toubuntu-latestrunner matches the rest of your release pipeline. Double-check that native glibc compatibility is acceptable here.
265-266: Standardize runner OS forlib-release
Updated toubuntu-latestfor consistency with the other release jobs.
321-322: Standardize runner OS for finalreleasejob
Usingubuntu-latesthere completes the alignment of all Linux-based jobs in your pipeline.
Summary by CodeRabbit
sudoin package installations within the containerized workflow.