Updating version for bundler for 2.X.X #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for stack(s) cflinuxfs4
Regenerated Gemfile.lock files with bundler 2.7.2 to fix compatibility issues. Updated fixtures: - specified_ruby_version: 2.4.1 -> 2.7.2 - relative_gemspec_path: 2.4.1 -> 2.7.2 - rails7: 2.4.19 -> 2.7.2 - ruby_calls_go: 2.6.2 -> 2.7.2
Bundler 2.7+ philosophy: 'Bundler itself does not use binstubs because its version is selected by RubyGems' The regenerateBundlerBinStub() function was added in 2017 (commit fe6e899) to work around bundler 1.16.0 incompatibility with Rails-generated binstubs. This workaround is no longer necessary because: 1. The original Rails binstub bug was fixed years ago 2. Bundler 2.7+ explicitly refuses to create its own binstub by design 3. The buildpack doesn't use deps/0/bin/bundle anyway - it uses the system bundle command from deps/0/bundler (configured via GEM_PATH) 4. Modern bundler philosophy is to use the system bundle, not a binstub Changes: - Removed regenerateBundlerBinStub() function - Removed call to regenerateBundlerBinStub() from InstallGems() - Removed related unit tests (setupBundlerBin, itRegeneratesBundleBinstub) - All 76 unit tests pass This aligns the buildpack with bundler 2.7+ architectural decisions.
ramonskie
force-pushed
the
pr-by-releng-bot-1769608601
branch
from
a0edaaa to
ebc60e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is default description of the PR