fix: tests marked both passed and failed when a [Failure] method exists
#198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the methods run from a suite depend on the TestOp type, make TestOp responsible for knowing which methods to run, instead of using pattern-matching on the type. Avoids bugs if more TestOp types are added in future and supports mocking TestOp in tests, as well.
Added a test to verify that failing [Test] methods are not marked Passed when a [Failure] method exists in the suite. This test is currently failing.
When a [Failure] method exists in the test suite, failing methods are only marked failed. The test executor correctly reports passed/failed status for the [Failure] method when executing it, instead of the test method that triggered the failure. Previously, failing methods in a suite with a [Failure] method were marked passed after being marked failed, and status for the [Failure] method was not reported.
jolexxa
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197.
When a
[Failure]method exists in the test suite, failing tests are now only marked failed. The test executor now correctly reports passed/failed status for the[Failure]method when executing it, instead of the test method that triggered the failure.Previously, failing tests in a suite with a
[Failure]method were marked passed after being marked failed, and status for the[Failure]method was not reported.