fix: do not resolve ICE server hostnames during IMAP loop #7725
+119
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
approved these changes
Jan 15, 2026
WofWca
reviewed
Jan 15, 2026
Collaborator
WofWca
left a comment
WofWca
left a comment
There was a problem hiding this comment.
Now the DNS resolution is only done inside of fn ice_servers, which makes sense.
link2xt
force-pushed
the
link2xt/loylkzmwllkk
branch
from
abd4cf3 to
4aec967
Compare
link2xt
force-pushed
the
link2xt/loylkzmwllkk
branch
from
4aec967 to
84600a5
Compare
Hostname resolution may timeout if DNS servers are not responding. It is also not necessary to resolve fallback ICE server hostnames if the user is not going to use calls.
link2xt
force-pushed
the
link2xt/loylkzmwllkk
branch
from
84600a5 to
8257ea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hostname resolution may timeout if DNS servers are not responding. It is also not necessary to resolve fallback ICE server hostnames if the user is not going to use calls.
Fixes #7710