Skip to content

Conversation

@Herklos
Copy link

@Herklos Herklos commented Nov 10, 2025

It fixes the missing flag to build aiohttp wheel

@mhsmith
Copy link
Member

mhsmith commented Nov 11, 2025

Thanks, I'll look at this as soon as I can.

@IsakTheHacker
Copy link
Contributor

@Herklos Since updates aren't added that often, it would be awesome if you could bump the version to the latest one (aiohttp 3.13.2) while you're at it.

@Herklos
Copy link
Author

Herklos commented Nov 27, 2025

@Herklos Since updates aren't added that often, it would be awesome if you could bump the version to the latest one (aiohttp 3.13.2) while you're at it.

Right! I just updated to the latest version.

@mhsmith
Copy link
Member

mhsmith commented Nov 29, 2025

Thanks for the contribution, but since cibuildwheel now has Android support, it would be more efficient to submit a PR to this package's own repository, like those linked at #1417 (comment). That way we can get Android wheels not just for the current version, but for all future versions too.

Since cibuildwheel builds packages in a virtual environment which simulates Android, it's likely that this would also allow the -fPIC patch to be avoided.

@mhsmith mhsmith changed the title Fix aiohttp build Update aiohttp, and add aiodns Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants