-
Notifications
You must be signed in to change notification settings - Fork 179
upgrade opencv-python package to 4.11.0.86 #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks, I'll look at this as soon as I can. Meanwhile, can you confirm you've tested this as described in the "Testing a package" section in the README? Once you've done that, please let me know which Python versions and ABIs you've tested. You don't need to do them all, but you should do at least one. |
|
|
||
| # try to use dynamic symbols linking with libpython.so | ||
| set(OPENCV_FORCE_PYTHON_LIBS OFF CACHE BOOL "") | ||
| + string(REPLACE "-Wl,--no-undefined-version" "" CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS}") # Chaquopy: fixbug for '-version' while compiling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the "Chaquopy" comment onto its own line above the change, and edit it to explain exactly why the change is necessary, including any error messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll update when test is passed.
I'm doing test with android studio as described in README. The python version is 3.10 and ABI is x86_64. I've checked the build history, and found that config.py was built and packed into the wheel. Then I checked files in pkgtest/app/build/python/pip/debug/common/cv2 in the pkgtest app in android studio, and found following .py files except config.py. And I found config.py in pkgtest/app/build/python/pip/debug/x86_64/cv2. Can you please identify this issue? |
|
If the file is in debug/x86_64 but not in debug/common, then you must be installing multiple ABIs, and the file is different between them. This is not in itself a problem, as the directories will be merged back together at runtime by the importer. But you can simplify the situation by temporarily editing the It looks like the actual problem is that OpenCV expects |
upgrade opencv-python package to 4.11.0.86.