Skip to content

Conversation

@ReinierMaas
Copy link

XRef: #1

Alternative implementation that makes it possible to use a custom open_socket function.

@ReinierMaas ReinierMaas self-assigned this Nov 25, 2025
@ReinierMaas
Copy link
Author

Note: This doesn't expose enough information because socket address is hidden in the implementation in the curl library... We need access to the underlying curl-sys handle...

@ReinierMaas
Copy link
Author

I have made changes to curl-rust that allow us to perform blacklisting at the socket level. Currently awaiting the fork to push those changes for review.

I still have to move the moment that we allow setting the custom_open_socket because as I am trying out this interface I detected that we can't communicate back to the call-site of get_async.

This allows the caller to create a structure that is available during the `open_socket` evaluation
Copy link

@SanderHageman SanderHageman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! the DefaultOpenSocketHandler looks a bit cursed but I can't immediately think of a better implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants