Add test for mysql zero scale column def fix #2378
Merged
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <[email protected]>
MasterOdin
force-pushed
the
chore-add-tests
branch
from
f1b7578 to
ea64449
Compare
Member
|
What PR/issue was that related to? |
Member
Author
|
@dereuromark #2377, which you merged 4 days ago without any tests. I suspect there's also a similar bug in the implementation for at least sqlserver as well, though that's a bit more tricky as whereas mysql requires both of precision and scale or neither, sqlserver allows omitting scale per their docs. |
MasterOdin
changed the title
MasterOdin
changed the title
MasterOdin
changed the title
Member
|
True, but the fix was quite obvious from the PR. |
Member
Author
|
Regardless of simplicity of a given fix, I would still like to see tests to prevent regressions in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds a test for the fix done in #2377, validating the case where when
scaleis set to0, then we do still getdecimal(15,0)in the column definition.For reference, the default value for precision if the arguments are omitted is 10.