add cvm kind of vm in jvm.cfg #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duanyangjing
approved these changes
Nov 7, 2025
luchsh
reviewed
Nov 7, 2025
cvm.mk
Outdated
| echo "-server KNOWN" >> $(CVM8_LIBDIR)/jvm.cfg | ||
| echo "-client IGNORE" >> $(CVM8_LIBDIR)/jvm.cfg | ||
| echo "-server17 KNOWN" > $(OUTPUTDIR)/$(DISTRO_NAME)/jre/lib/$(ARCH_DIR)/jvm.cfg | ||
| echo "-cvm KNOWN" >> $(OUTPUTDIR)/$(DISTRO_NAME)/jre/lib/$(ARCH_DIR)/jvm.cfg |
Collaborator
There was a problem hiding this comment.
can we generate $(CVM8_LIBDIR)/jvm.cfg and copy to $(OUTPUTDIR)/$(DISTRO_NAME)/jre/lib/$(ARCH_DIR)/?
luchsh
reviewed
Nov 7, 2025
cvm.mk
Outdated
| cp -f $(SRC_BUILDDIR_17)/jdk/lib/server/libjvm.debuginfo $(CVM8_LIBDIR)/server17/libjvm.debuginfo && \ | ||
| [[ "x$$(grep server17 $(CVM8_LIBDIR)/jvm.cfg)" = "x" ]] && echo "-server17 KNOWN" >> $(CVM8_LIBDIR)/jvm.cfg && \ | ||
| [[ "x$$(grep cvm $(CVM8_LIBDIR)/jvm.cfg)" = "x" ]] && echo "-cvm KNOWN" >> $(CVM8_LIBDIR)/jvm.cfg; \ | ||
| pushd $(CVM8_LIBDIR) && rm -rf cvm && ln -sf server17 cvm && popd; \ |
Collaborator
There was a problem hiding this comment.
ln -sf is enough, manpage says:
NAME
ln - make links between files
......
-f, --force
remove existing destination files
both -server17 and -cvm are supported and they indicate the same vm.
superajun-wsj
force-pushed
the
jdk17u-target8-cvm-compatible
branch
from
59a0693 to
85292a2
Compare
luchsh
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both -server17 and -cvm are supported and they indicate the same vm.