chore: AXE-2572 Axe-core Upgrade Phase 2 #178

gaganmBrowserStack · 2025-12-29T08:34:23Z

<< Describe the changes >>

Closes:

Making heading-order & heading-order-bp stable

…ase 2

…y-engine-axe-core into Upgrade-to-4.11

…-engine-axe-core into Upgrade-to-4.11

deploybs-com · 2026-01-02T11:17:06Z

Error found in CSV related to Git Merge:

Error occured while merging master/main - Cmd('git') failed due to: exit code(1)
cmdline: git merge main
stdout: 'Auto-merging lib/rules/p-as-heading.json
CONFLICT (content): Merge conflict in lib/rules/p-as-heading.json
Auto-merging lib/rules/label-content-name-mismatch.json
CONFLICT (content): Merge conflict in lib/rules/label-content-name-mismatch.json
Auto-merging doc/rule-descriptions.md
CONFLICT (content): Merge conflict in doc/rule-descriptions.md
Auto-merging build/tasks/validate.js
Automatic merge failed; fix conflicts and then commit the result.'

deploybs-com · 2026-01-07T12:36:26Z

Error found in CSV related to Git Merge:

Error occured while merging master/main - Cmd('git') failed due to: exit code(1)
cmdline: git merge main
stdout: 'Auto-merging doc/rule-descriptions.md
CONFLICT (content): Merge conflict in doc/rule-descriptions.md
Auto-merging build/tasks/validate.js
Automatic merge failed; fix conflicts and then commit the result.'

deploybs-com · 2026-01-07T12:42:44Z

Error found in CSV related to Git Merge:

Error occured while merging master/main - Cmd('git') failed due to: exit code(1)
cmdline: git merge main
stdout: 'Auto-merging doc/rule-descriptions.md
CONFLICT (content): Merge conflict in doc/rule-descriptions.md
Automatic merge failed; fix conflicts and then commit the result.'

deploybs-com · 2026-01-07T13:49:38Z

Error found in CSV related to Git Merge:

Error occured while merging master/main - Cmd('git') failed due to: exit code(1)
cmdline: git merge main
stdout: 'Auto-merging doc/rule-descriptions.md
CONFLICT (content): Merge conflict in doc/rule-descriptions.md
Automatic merge failed; fix conflicts and then commit the result.'

deploybs-com · 2026-01-08T07:43:45Z

Error found in CSV related to Git Merge:

Error occured while merging master/main - Cmd('git') failed due to: exit code(1)
cmdline: git merge main
stdout: 'Auto-merging doc/rule-descriptions.md
CONFLICT (content): Merge conflict in doc/rule-descriptions.md
Automatic merge failed; fix conflicts and then commit the result.'

deploybs-com · 2026-01-08T07:45:35Z

Error found in CSV related to Git Merge:

Error occured while merging master/main - Cmd('git') failed due to: exit code(1)
cmdline: git merge main
stdout: 'Auto-merging doc/rule-descriptions.md
CONFLICT (content): Merge conflict in doc/rule-descriptions.md
Automatic merge failed; fix conflicts and then commit the result.'

deploybs-com · 2026-01-08T08:34:07Z

Error found in CSV related to Git Merge:

Error occured while merging master/main - Cmd('git') failed due to: exit code(1)
cmdline: git merge main
stdout: 'Auto-merging doc/rule-descriptions.md
CONFLICT (content): Merge conflict in doc/rule-descriptions.md
Automatic merge failed; fix conflicts and then commit the result.'

…e-core into AXE-2572-phase-2-analysis-and-segregation-of-enhancements

deploybs-com · 2026-01-08T08:39:15Z

Error found in CSV related to Git Merge:

Error occured while merging master/main - Cmd('git') failed due to: exit code(1)
cmdline: git merge main
stdout: 'Auto-merging doc/rule-descriptions.md
CONFLICT (content): Merge conflict in doc/rule-descriptions.md
Automatic merge failed; fix conflicts and then commit the result.'

Abhi3685 · 2026-01-08T18:32:27Z

lib/core/utils/dq-element.js

 function getSource(element) {
-  if (!element?.outerHTML) {
+  if (!element) {
    return '';
  }
-  var source = element.outerHTML;
-  if (!source && typeof window.XMLSerializer === 'function') {
-    source = new window.XMLSerializer().serializeToString(element);
-  }
-  let htmlString = truncate(source || '');
-  // Remove unwanted attributes
-  const regex = /\s*data-percy-[^=]+="[^"]*"/g;
-  htmlString = htmlString.replace(regex, '');
-  return htmlString;
+
+  return truncateElement(element);
 }


reverting a11y-engine changes here - pls check

Abhi3685 · 2026-01-08T18:58:02Z

.github/workflows/deploy.yml

disable or remove this workflow - not applicable for us

Abhi3685 · 2026-01-08T19:05:49Z

.github/workflows/test.yml

rebase PR towards release branch to test out this workflow post merge

Abhi3685 · 2026-01-08T19:10:49Z

lib/core/base/rule.js

-Rule.prototype._logGatherPerformance = function _logGatherPerformance() {
-  // log('gather (', nodes.length, '):', performanceTimer.timeElapsed() + 'ms');
+Rule.prototype._logGatherPerformance = function _logGatherPerformance(nodes) {
+  log(


does this log show up in browser console?

Abhi3685 · 2026-01-08T19:12:44Z

lib/core/utils/get-ancestry.js

-    let index = 0;
-    if (parent.nodeName === 'BODY') {
-      let count = 0;
-      // Single pass over siblings: count valid children & locate node position.
-      for (
-        let sib = parent.firstElementChild;
-        sib;
-        sib = sib.nextElementSibling
-      ) {
-        if (sib.hasAttribute('data-percy-injected')) {
-          continue;
-        }
-        count++;
-        if (sib === node) {
-          index = count;
-        }
-      }
-      nthChild = count > 1 ? `:nth-child(${index})` : '';
-    } else {
-      index = Array.prototype.indexOf.call(parent.children, node) + 1;
-      nthChild = `:nth-child(${index})`;
-    }


a11y-engine changes are getting reverted

Abhi3685 · 2026-01-08T19:19:35Z

lib/core/utils/performance-timer.js

-
-      // this.logMeasures('axe');
+      this.measure('axe', 'mark_axe_start', 'mark_axe_end', true);
+      this.logMeasures('axe');


getting reverted - pls verify

Abhi3685 · 2026-01-08T19:20:08Z

lib/core/utils/performance-timer.js

+      );
      // log audit/rule measures
-      // this.logMeasures();
+      this.logMeasures(); // was commented out previously


same as above

Abhi3685 · 2026-01-08T19:22:16Z

lib/core/utils/performance-timer.js

-      if (window.performance && window.performance.measure !== undefined) {
-        if (Object.keys(details).length > 0) {
-          const measureOpts = {
-            detail: details,
-            start: startMark,
-            end: endMark
-          };
-          window.performance.measure(measureName, measureOpts);
-        } else {
-          window.performance.measure(measureName, startMark, endMark);
-        }


a11y-engine changes getting reverted

Abhi3685 · 2026-01-08T19:24:03Z

lib/core/utils/performance-timer.js

+     * Starts from the most recent start()/auditStart() call.
+     * @param {String|undefined} measureName If provided, will only log up to the first matching measure.
     */
    logMeasures(measureName) {


this function should be commented everywhere it is getting called

gaganmBrowserStack and others added 22 commits December 9, 2025 01:24

Phase 1: Adding New Rules

7da6bec

Initial merge

bc346a3

Phase1.25

e78afa3

minor changes

4480a9a

Minor changes

dbb5108

Minor Changes

86f13b9

Should change reverted

4d88749

Reverting old changes

66b6d94

Making heading-order & heading-order-bp stable

be6d6ca

Merge pull request #173 from browserstack/AXE-2606-heading-order-stable

edd8944

Making heading-order & heading-order-bp stable

"Ensure" compliance with changes

2a7bdc8

reverting labelContentNameMismatchEvaluate changes it should be in Ph…

5eebebb

…ase 2

Resolving PR review comments

8ca765f

reverting minor change

271dceb

updating _template.json

1cca3ae

minor fix for eslint issue

8ce63e3

Merge branch 'Upgrade-to-4.11' of https://github.com/browserstack/a11…

d14e9de

…y-engine-axe-core into Upgrade-to-4.11

🤖 Automated formatting fixes

b45d65a

Merge branch 'release-5.14.0' of https://github.com/browserstack/a11y…

8bcbcfb

…-engine-axe-core into Upgrade-to-4.11

Adding Bucket 1

b1afcf6

Adding Bucket 2

3456640

Adding Bucket 3

9740c0a

gaganmBrowserStack changed the title ~~Adding Bucket 1~~ chore: Axe-core Upgrade Phase 2 Dec 29, 2025

gaganmBrowserStack changed the title ~~chore: Axe-core Upgrade Phase 2~~ chore: AXE-2572 Axe-core Upgrade Phase 2 Dec 29, 2025

gaganmBrowserStack added 2 commits December 29, 2025 17:10

Package-lock Update

b447b0c

minor change

76ba588

Base automatically changed from release-5.14.0 to main January 2, 2026 11:15

syncing imp changes

0c6e26e

syncing imp changes

bbded80

gaganmBrowserStack changed the base branch from main to 4.9.0-upgrade January 7, 2026 13:43

gaganmBrowserStack changed the base branch from 4.9.0-upgrade to main January 7, 2026 13:43

gaganmBrowserStack changed the base branch from main to Upgrade-to-4.11 January 8, 2026 07:42

gaganmBrowserStack changed the base branch from Upgrade-to-4.11 to main January 8, 2026 07:43

gaganmBrowserStack changed the base branch from main to Upgrade-to-4.11 January 8, 2026 08:32

gaganmBrowserStack changed the base branch from Upgrade-to-4.11 to main January 8, 2026 08:37

Merge branch 'main' of https://github.com/browserstack/a11y-engine-ax…

d8fd6fa

…e-core into AXE-2572-phase-2-analysis-and-segregation-of-enhancements

rule-descriptions.md change

396ccc8

Abhi3685 requested changes Jan 8, 2026

View reviewed changes

chore: AXE-2572 Axe-core Upgrade Phase 2 #178

Are you sure you want to change the base?

chore: AXE-2572 Axe-core Upgrade Phase 2 #178

Conversation

gaganmBrowserStack commented Dec 29, 2025

Uh oh!

deploybs-com commented Jan 2, 2026

Uh oh!

deploybs-com commented Jan 7, 2026

Uh oh!

deploybs-com commented Jan 7, 2026

Uh oh!

deploybs-com commented Jan 7, 2026

Uh oh!

deploybs-com commented Jan 8, 2026

Uh oh!

deploybs-com commented Jan 8, 2026

Uh oh!

deploybs-com commented Jan 8, 2026

Uh oh!

deploybs-com commented Jan 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants