-
-
Notifications
You must be signed in to change notification settings - Fork 12
Initial Implementation of QR Replacement Library (with react-qr-scanner) #2474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2474 +/- ##
==========================================
+ Coverage 77.71% 77.90% +0.18%
==========================================
Files 279 279
Lines 19642 19591 -51
Branches 1949 1949
==========================================
- Hits 15265 15262 -3
+ Misses 4331 4283 -48
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pylipp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, I was struggling with finding the printscreen button there 😂 Looking forward to the review :) |
Signed-off-by: Philipp Metzner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review passed
great, clean work @MomoRazor !
functional review
1.) The new QrReader behaves differently regarding "Re-scanning". The delayBetweenScanAttempts is different than before. Any idea why @MomoRazor ? I attached a video for this. Without a known reason it would be a blocker for me.
Screencast.2025-12-15.17.02.03.mp4
2.) Due to former bugs with IPhone, I would like an iPhone user to test before release on staging.

The first implemention of the QR Reader Scanner using the primary option (@yudiel/react-qr-scanner)
https://trello.com/c/Zv00dw2j