Skip to content

Conversation

@MomoRazor
Copy link
Contributor

@MomoRazor MomoRazor commented Nov 25, 2025

The first implemention of the QR Reader Scanner using the primary option (@yudiel/react-qr-scanner)

https://trello.com/c/Zv00dw2j

@sentry
Copy link

sentry bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.90%. Comparing base (80f7396) to head (ce96c35).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2474      +/-   ##
==========================================
+ Coverage   77.71%   77.90%   +0.18%     
==========================================
  Files         279      279              
  Lines       19642    19591      -51     
  Branches     1949     1949              
==========================================
- Hits        15265    15262       -3     
+ Misses       4331     4283      -48     
  Partials       46       46              
Flag Coverage Δ
backend 99.55% <ø> (ø)
frontend 70.03% <ø> (+0.23%) ⬆️
sharedComponents 61.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pylipp pylipp requested a review from HaGuesto November 25, 2025 09:48
@MomoRazor
Copy link
Contributor Author

Apologies forgot to upload a screenshot

Screenshot from 2025-11-25 16-16-16

Copy link
Contributor

@pylipp pylipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review passes , I'll leave the code review to @HaGuesto and @jlin95 .
Tested single- and multi-box scan.
Really enthusiastic screenshot btw 😉

@pylipp pylipp requested a review from jlin95 November 26, 2025 17:25
@MomoRazor
Copy link
Contributor Author

Really enthusiastic screenshot btw 😉

For some reason, I was struggling with finding the printscreen button there 😂

Looking forward to the review :)

Copy link
Member

@HaGuesto HaGuesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review passed

great, clean work @MomoRazor !

functional review

1.) The new QrReader behaves differently regarding "Re-scanning". The delayBetweenScanAttempts is different than before. Any idea why @MomoRazor ? I attached a video for this. Without a known reason it would be a blocker for me.

Screencast.2025-12-15.17.02.03.mp4

2.) Due to former bugs with IPhone, I would like an iPhone user to test before release on staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants