feat(transmit): getAllSubscribersUUIDs #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainLanz
reviewed
Jun 23, 2025
src/transmit.ts
Outdated
| await this.#bus?.disconnect() | ||
| } | ||
|
|
||
| getAllSubscribersUUIDs(channel: string) { |
Member
There was a problem hiding this comment.
Suggested change
| getAllSubscribersUUIDs(channel: string) { | |
| getSubscribersFor(channel: string) { |
RomainLanz
reviewed
Jun 23, 2025
src/transmit.ts
Outdated
Comment on lines
240
to
241
| const uuids = Array.from(subscribers).map((subscriber) => subscriber.getUid()) | ||
| return uuids |
Member
There was a problem hiding this comment.
Suggested change
| const uuids = Array.from(subscribers).map((subscriber) => subscriber.getUid()) | |
| return uuids | |
| return Array.from(subscribers).map((subscriber) => subscriber.getUid()) |
Member
|
Thanks for the PR! Sorry for the delay, it got lost in my notification 😅 |
Contributor
Author
|
Oh nice, windows tests seems to work fine again |
Member
Yes, SWC fixed their issue! Could you change a bit the test to create another subscription to another channel to ensure it works as expected? |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #21