Add elasticgraph-warehouse_lambda #863
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwils
force-pushed
the
joshuaw/warehouse_lambda
branch
from
d66bc3e to
d4a0486
Compare
This migrates the existing square internal gem to the open source elasticgraph repo.
jwils
force-pushed
the
joshuaw/warehouse_lambda
branch
from
d4a0486 to
5cfe8e8
Compare
fasihawan
reviewed
Oct 6, 2025
| params = payload_body.fetch(:script).fetch(:params) | ||
| data = params.fetch("data").merge({ | ||
| "id" => params.fetch("id"), | ||
| "__eg_version" => params.fetch("version") |
Contributor
There was a problem hiding this comment.
This is the only metadata that needs to be set within EG? Can a comment be added for this?
| # `elasticgraph-indexer` so that it can be used in place of the standard datastore indexing router: | ||
| # | ||
| # https://github.com/squareup/elasticgraph-public/blob/v0.18.0.5/elasticgraph-indexer/lib/elastic_graph/indexer/datastore_indexing_router.rb#L76 | ||
| class WarehouseDumper |
Contributor
There was a problem hiding this comment.
Will this only support JSONL or can parquet/avro/other options be supported in the future?
|
|
||
| def compress(jsonl_data) | ||
| io = ::StringIO.new | ||
| gz = ::Zlib::GzipWriter.new(io) |
Contributor
There was a problem hiding this comment.
Aside: Was snappy ever considered over gzip?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the existing square internal gem to the open source elasticgraph repo.