-
Notifications
You must be signed in to change notification settings - Fork 46
feat(bdk_wallet): add get_keymap() helper method to get the KeyMap for Psbt.sign #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 18873961904Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
If I understand correctly, this method relies on the wallet having access to the private keys in order to produce this map, but the new 3.0 wallet will not have access to those, so the method is not really useful for 3.0 users, nor as an example for how to perform signing when a wallet doesn't have private descriptors. |
|
@GideonBature your approach isn't quite what we're looking for. Can you try updating this PR or creating a new one based on @ValuedMammal's recent comment on #331? see: #331 (comment) |
That's right... |
That's right...
I will check it out now and make the update... |
Description
This PR adds a new helper method get_keymap() to the Wallet struct that returns a combined KeyMap containing all signing keys from both external and internal (change) signers.
Notes to the reviewers
Changelog notice
Added Wallet::get_keymap() helper method to retrieve a combined KeyMap from all wallet signers for convenient PSBT signing
Checklists
All Submissions:
just pbefore pushingNew Features:
Bugfixes:
Closes #331