Skip to content

Conversation

@afurm
Copy link
Contributor

@afurm afurm commented Dec 21, 2025

Summary

  • Move tray item height from a local magic number into a global CSS token.
  • Keep tray layout sizing consistent via --tray-item-height.

Testing

  • Not run (CSS-only change).

@jorgemanrubia jorgemanrubia requested a review from andyra January 7, 2026 15:29
@jorgemanrubia
Copy link
Member

This makes sense to me. What do you think @andyra?

@andyra
Copy link
Contributor

andyra commented Jan 7, 2026

I'm not quite sure this is an improvement. We still have a magic (i.e. arbitrary) number, but now it's further away from where we use it. Since this variable is only used in trays.css, there's not any advantage to hoisting it up to _global.css (usually reserved for tokens that are used throughout the app).

I suggest we keep this as-is—unless, of course, I'm missing something!

@afurm afurm deleted the tray-item-height-token branch January 7, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants